Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread Christoph Hellwig 
On Sun, Aug 27, 2006 at 03:08:41AM +0400, Alexey Dobriyan wrote:
 Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
 ---
 
  Forgive me reformatting, in some cases making it fit in 80 columns was hard.
 
  net/core/flow.c|6 +-
  net/core/neighbour.c   |   12 
  net/core/skbuff.c  |9 ++---
  net/decnet/dn_route.c  |   11 +++
  net/ipv4/inetpeer.c|5 +
  net/ipv4/ipmr.c|5 +
  net/ipv4/route.c   |   10 +++---
  net/ipv4/tcp.c |4 +---
  net/ipv6/ip6_fib.c |4 +---
  net/ipv6/route.c   |   10 +++---

ipv6 can be modular, so panicing on a initialization failure is wrong.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread David Miller 
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Mon, 28 Aug 2006 10:36:51 +0100

 ipv6 can be modular, so panicing on a initialization failure is wrong.

That may be the case, but he merely translated the code
as it existed, he didn't change it to start panic()'ing
it already did.

It would be a seperate change to undo the panic() in
the ipv6 code.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-28 Thread Alexey Dobriyan 
On Mon, Aug 28, 2006 at 01:36:37PM -0700, David Miller wrote:
  ipv6 can be modular, so panicing on a initialization failure is wrong.

 That may be the case, but he merely translated the code
 as it existed, he didn't change it to start panic()'ing
 it already did.

 It would be a seperate change to undo the panic() in
 the ipv6 code.

That separate change transformed into big cleanup of IPV6 init/exit
codepaths to fix panic properly. Will be posted soon.

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/*: use SLAB_PANIC

2006-08-26 Thread David Miller 
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Sun, 27 Aug 2006 03:08:41 +0400

 Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]

Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html