Re: [PATCH] rtl8xxxu: hide unused tables
Kalle Valo writes: > Jes Sorensen writes: > >> Arnd Bergmann writes: >>> The references to some arrays in the rtl8xxxu driver were moved inside >>> of an #ifdef, but the symbols remain outside, resulting in build warnings: >>> >>> rtl8xxxu/rtl8xxxu.c:1506:33: error: >>> 'rtl8188ru_radioa_1t_highpa_table' defined but not used >>> rtl8xxxu/rtl8xxxu.c:1431:33: error: >>> 'rtl8192cu_radioa_1t_init_table' defined but not used >>> rtl8xxxu/rtl8xxxu.c:1407:33: error: >>> 'rtl8192cu_radiob_2t_init_table' defined but not used >>> rtl8xxxu/rtl8xxxu.c:1332:33: error: >>> 'rtl8192cu_radioa_2t_init_table' defined but not used >>> rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not >>> used >>> rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not >>> used >>> >>> This adds an extra #ifdef around them to shut up the warnings. >>> >>> Signed-off-by: Arnd Bergmann >>> Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") >>> Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device >>> specific functions") >>> --- >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 >>> 1 file changed, 4 insertions(+) >> >> I'll apply it to my tree! > > Actually I would prefer to apply this directly to wireless-drivers-next > so that the warnings are quickly fixed. Thats fine with me, I already applied it here before I started doing any of the refactoring work, so we should be in sync. Cheers, Jes
Re: [PATCH] rtl8xxxu: hide unused tables
Jes Sorensen writes: > Arnd Bergmann writes: >> The references to some arrays in the rtl8xxxu driver were moved inside >> of an #ifdef, but the symbols remain outside, resulting in build warnings: >> >> rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' >> defined but not used >> rtl8xxxu/rtl8xxxu.c:1431:33: error: 'rtl8192cu_radioa_1t_init_table' defined >> but not used >> rtl8xxxu/rtl8xxxu.c:1407:33: error: 'rtl8192cu_radiob_2t_init_table' defined >> but not used >> rtl8xxxu/rtl8xxxu.c:1332:33: error: 'rtl8192cu_radioa_2t_init_table' defined >> but not used >> rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used >> rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used >> >> This adds an extra #ifdef around them to shut up the warnings. >> >> Signed-off-by: Arnd Bergmann >> Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") >> Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific >> functions") >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 >> 1 file changed, 4 insertions(+) > > I'll apply it to my tree! Actually I would prefer to apply this directly to wireless-drivers-next so that the warnings are quickly fixed. -- Kalle Valo
Re: [PATCH] rtl8xxxu: hide unused tables
Arnd Bergmann writes: > The references to some arrays in the rtl8xxxu driver were moved inside > of an #ifdef, but the symbols remain outside, resulting in build warnings: > > rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' > defined but not used > rtl8xxxu/rtl8xxxu.c:1431:33: error: 'rtl8192cu_radioa_1t_init_table' defined > but not used > rtl8xxxu/rtl8xxxu.c:1407:33: error: 'rtl8192cu_radiob_2t_init_table' defined > but not used > rtl8xxxu/rtl8xxxu.c:1332:33: error: 'rtl8192cu_radioa_2t_init_table' defined > but not used > rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used > rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used > > This adds an extra #ifdef around them to shut up the warnings. > > Signed-off-by: Arnd Bergmann > Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") > Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific > functions") > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 > 1 file changed, 4 insertions(+) I'll apply it to my tree! Thanks, Jes