Re: [PATCH] samples/bpf: Add tunnel set/get tests.
On 08/16/2016 04:03 PM, William Tu wrote:
The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key,
and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native
tunnel device is created in a namespace to interact with a lwtunnel
device out of the namespace, with metadata enabled. The bpf_skb_set_*
program is attached to tc egress and bpf_skb_get_* is attached to egress
qdisc. A ping between two tunnels is used to verify correctness and
the result of bpf_skb_get_* printed by bpf_trace_printk.
Signed-off-by: William Tu
For net-next tree. LGTM, thanks!
Acked-by: Daniel Borkmann
Re: [PATCH] samples/bpf: Add tunnel set/get tests.
On Tue, Aug 16, 2016 at 07:03:01AM -0700, William Tu wrote:
> The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key,
> and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native
> tunnel device is created in a namespace to interact with a lwtunnel
> device out of the namespace, with metadata enabled. The bpf_skb_set_*
> program is attached to tc egress and bpf_skb_get_* is attached to egress
> qdisc. A ping between two tunnels is used to verify correctness and
> the result of bpf_skb_get_* printed by bpf_trace_printk.
>
> Signed-off-by: William Tu
nice test. thanks!
Acked-by: Alexei Starovoitov
Re: [PATCH] samples/bpf: Add tunnel set/get tests.
From: William Tu
Date: Tue, 16 Aug 2016 07:03:01 -0700
> The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key,
> and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native
> tunnel device is created in a namespace to interact with a lwtunnel
> device out of the namespace, with metadata enabled. The bpf_skb_set_*
> program is attached to tc egress and bpf_skb_get_* is attached to egress
> qdisc. A ping between two tunnels is used to verify correctness and
> the result of bpf_skb_get_* printed by bpf_trace_printk.
>
> Signed-off-by: William Tu
Please respin, this doesn't apply cleanly to net-next.
Re: [PATCH] samples/bpf: Add tunnel set/get tests.
Thanks, I've submitted newer version.
On Thu, Aug 18, 2016 at 9:10 PM, David Miller wrote:
> From: William Tu
> Date: Tue, 16 Aug 2016 07:03:01 -0700
>
>> The patch creates sample code exercising bpf_skb_{set,get}_tunnel_key,
>> and bpf_skb_{set,get}_tunnel_opt for GRE, VXLAN, and GENEVE. A native
>> tunnel device is created in a namespace to interact with a lwtunnel
>> device out of the namespace, with metadata enabled. The bpf_skb_set_*
>> program is attached to tc egress and bpf_skb_get_* is attached to egress
>> qdisc. A ping between two tunnels is used to verify correctness and
>> the result of bpf_skb_get_* printed by bpf_trace_printk.
>>
>> Signed-off-by: William Tu
>
> Please respin, this doesn't apply cleanly to net-next.
