Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
Atsushi Nemoto wrote: The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. applied to #upstream - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
Atsushi Nemoto wrote: On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger [EMAIL PROTECTED] wrote: + * 1.35Fix an usage of streaming DMA API. */ Please don't use comments as changelog anymore. It gets out of date. The use of change control systems has made this practice obsolete. OK, Jeff, should I send a revised patch dropping this line? Nah, there's no need to reject the patch on that basis. You should send an additional patch, on top of all others you sent recently, that completely removes the entire changelog from the driver source code :) Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
On Wed, 14 Mar 2007 05:59:51 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: OK, Jeff, should I send a revised patch dropping this line? Nah, there's no need to reject the patch on that basis. You should send an additional patch, on top of all others you sent recently, that completely removes the entire changelog from the driver source code :) OK, Done :) --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
On Wed, 14 Mar 2007 01:02:20 +0900 (JST) Atsushi Nemoto [EMAIL PROTECTED] wrote: The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index ec888db..eed78b5 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -58,12 +58,13 @@ * 1.34Fix netpoll locking. BH rule for NAPI is not enough with * netpoll, hard_start_xmit might be called from irq context. * PM support. + * 1.35Fix an usage of streaming DMA API. */ Please don't use comments as changelog anymore. It gets out of date. The use of change control systems has made this practice obsolete. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tc35815: Fix an usage of streaming DMA API.
On Tue, 13 Mar 2007 12:04:18 -0700, Stephen Hemminger [EMAIL PROTECTED] wrote: + * 1.35Fix an usage of streaming DMA API. */ Please don't use comments as changelog anymore. It gets out of date. The use of change control systems has made this practice obsolete. OK, Jeff, should I send a revised patch dropping this line? --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
