Re: [PATCH] vmxnet3: repair memory leak
From: Neil Horman Date: Mon, 22 Jan 2018 16:06:37 -0500 > with the introduction of commit > b0eb57cb97e7837ebb746404c2c58c6f536f23fa, it appears that rq->buf_info > is improperly handled. While it is heap allocated when an rx queue is > setup, and freed when torn down, an old line of code in > vmxnet3_rq_destroy was not properly removed, leading to rq->buf_info[0] > being set to NULL prior to its being freed, causing a memory leak, which > eventually exhausts the system on repeated create/destroy operations > (for example, when the mtu of a vmxnet3 interface is changed > frequently. > > Fix is pretty straight forward, just move the NULL set to after the > free. > > Tested by myself with successful results > > Applies to net, and should likely be queued for stable, please > > Signed-off-by: Neil Horman > Reported-By: boy...@redhat.com Applied and queued up for -stable, thanks Neil.
Re: [PATCH] vmxnet3: repair memory leak
On Mon, 22 Jan 2018, Neil Horman wrote: > with the introduction of commit > b0eb57cb97e7837ebb746404c2c58c6f536f23fa, it appears that rq->buf_info > is improperly handled. While it is heap allocated when an rx queue is > setup, and freed when torn down, an old line of code in > vmxnet3_rq_destroy was not properly removed, leading to rq->buf_info[0] > being set to NULL prior to its being freed, causing a memory leak, which > eventually exhausts the system on repeated create/destroy operations > (for example, when the mtu of a vmxnet3 interface is changed > frequently. > > Fix is pretty straight forward, just move the NULL set to after the > free. > > Tested by myself with successful results > > Applies to net, and should likely be queued for stable, please > > Signed-off-by: Neil Horman > Reported-By: boy...@redhat.com Thank you for root causing and fixing this. Acked-by: Shrikrishna Khare