Re: [PATCH 0/8] net: mvpp2: add TX interrupts support
Hello, On Wed, 26 Jul 2017 13:35:33 -0700 (PDT), David Miller wrote: > > - This series depends on the previous series sent by Antoine Ténart > >"net: mvpp2: MAC/GoP configuration and optional PHYs". Functionally > >speaking there is no real dependency, but we touch in a few areas > >the same piece of code, so I based my patch series on top of > >Antoine's. > > > > - Please do not apply the last patch of this series "arm64: dts: > >marvell: add TX interrupts for PPv2.2", it will be taken by the ARM > >mvebu maintainers. > > Please don't do things this way. > > Patiently wait for Antione's series to make it into my tree, then > submit your's. I'll resubmit when Antoine's series is merged. The idea of submitting my patches was to allow others to review/test them, not necessarily to have them merged right away. Perhaps I should have marked them RFC to make it clear that I don't expect you to merge them right away. > Also, if we're continually going to elide the DTS file patches, just It's the dutty of the sub-architecture maintainers to merge the DTS changes. Merging them through your tree doesn't work really well, as the changes might very likely conflict with other DTS changes merged by the sub-architecture maintainer. But it makes sense to have such DTS changes in the same patch series, since they are really related. It's very common to have patch series that contain patches that will be merged by different maintainers. > don't bother adding them to the series. That way you don't have to > give me special instructions, and I don't have the possibility of > making a mistake and applying it accidently. ... but OK, I won't resend them, so you don't get potentially confused by such patches. Thanks! Thomas Petazzoni -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCH 0/8] net: mvpp2: add TX interrupts support
From: Thomas Petazzoni Date: Tue, 25 Jul 2017 17:55:01 +0200 > Hello, > > So far, the mvpp2 driver was using an hrtimer to handle TX > completion. This patch series adds support for using TX interrupts > (for each CPU) on PPv2.2, the variant of the IP used on Marvell Armada > 7K/8K. > > This series has been tested on Marvell Armada 7K (PPv2.2) and Armada > 375 (PPv2.1). > > Dave: > > - This series depends on the previous series sent by Antoine Ténart >"net: mvpp2: MAC/GoP configuration and optional PHYs". Functionally >speaking there is no real dependency, but we touch in a few areas >the same piece of code, so I based my patch series on top of >Antoine's. > > - Please do not apply the last patch of this series "arm64: dts: >marvell: add TX interrupts for PPv2.2", it will be taken by the ARM >mvebu maintainers. Please don't do things this way. Patiently wait for Antione's series to make it into my tree, then submit your's. Also, if we're continually going to elide the DTS file patches, just don't bother adding them to the series. That way you don't have to give me special instructions, and I don't have the possibility of making a mistake and applying it accidently. Thanks.
Re: [PATCH 0/8] net: mvpp2: add TX interrupts support
Hi Thomas, I tested patchset on A8040-DB, everything seems fine. Best regards, Marcin 2017-07-25 17:55 GMT+02:00 Thomas Petazzoni : > Hello, > > So far, the mvpp2 driver was using an hrtimer to handle TX > completion. This patch series adds support for using TX interrupts > (for each CPU) on PPv2.2, the variant of the IP used on Marvell Armada > 7K/8K. > > This series has been tested on Marvell Armada 7K (PPv2.2) and Armada > 375 (PPv2.1). > > Dave: > > - This series depends on the previous series sent by Antoine Ténart >"net: mvpp2: MAC/GoP configuration and optional PHYs". Functionally >speaking there is no real dependency, but we touch in a few areas >the same piece of code, so I based my patch series on top of >Antoine's. > > - Please do not apply the last patch of this series "arm64: dts: >marvell: add TX interrupts for PPv2.2", it will be taken by the ARM >mvebu maintainers. > > Thanks! > > Thomas > > Thomas Petazzoni (8): > net: mvpp2: fix MVPP21_ISR_RXQ_GROUP_REG definition > net: mvpp2: remove RX queue group reset code > net: mvpp2: introduce per-port nrxqs/ntxqs variables > net: mvpp2: move from cpu-centric naming to "software thread" naming > net: mvpp2: introduce queue_vector concept > net: mvpp2: add support for TX interrupts and RX queue distribution > modes > dt-bindings: net: marvell-pp2: update interrupt-names with TX > interrupts > arm64: dts: marvell: add TX interrupts for PPv2.2 > > .../devicetree/bindings/net/marvell-pp2.txt| 33 +- > .../boot/dts/marvell/armada-cp110-master.dtsi | 21 +- > .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 21 +- > drivers/net/ethernet/marvell/mvpp2.c | 638 > +++-- > 4 files changed, 534 insertions(+), 179 deletions(-) > > -- > 2.9.4 >
