Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README
Sat, Oct 29, 2016 at 01:46:59PM CEST, s...@narfation.org wrote: >On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: >[...] >> >> I strongly believe it is a huge mistake to use sysfs for things like >> >> this. This should be done via generic netlink api. >> > >> >This doesn't change the problem that it is already that way. This patch >> >only adds the list of available files to the README. >> >> Sure. Just found out you did it like that. Therefore I commented. I >> suggest to rework the api to use genl entirely. > >Fair enough, I have added it to the issue tracker [1]. > >It seems there is no easy way to drop support for modifying batman-adv >attributes of the interface or its ports via sysfs in the near >future. But disallowing sysfs for new attributes might be a viable >policy. Cool. Thanks! > >Kind regards, > Sven > >[1] https://www.open-mesh.org/issues/300
Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README
On Samstag, 29. Oktober 2016 12:56:28 CEST Jiri Pirko wrote: [...] > >> I strongly believe it is a huge mistake to use sysfs for things like > >> this. This should be done via generic netlink api. > > > >This doesn't change the problem that it is already that way. This patch > >only adds the list of available files to the README. > > Sure. Just found out you did it like that. Therefore I commented. I > suggest to rework the api to use genl entirely. Fair enough, I have added it to the issue tracker [1]. It seems there is no easy way to drop support for modifying batman-adv attributes of the interface or its ports via sysfs in the near future. But disallowing sysfs for new attributes might be a viable policy. Kind regards, Sven [1] https://www.open-mesh.org/issues/300 signature.asc Description: This is a digitally signed message part.
Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README
Sat, Oct 29, 2016 at 12:37:07PM CEST, s...@narfation.org wrote: >On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: >[...] >> >--- a/Documentation/networking/batman-adv.txt >> >+++ b/Documentation/networking/batman-adv.txt >> >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own >> >interface >> > folder: >> > >> > # ls /sys/class/net/bat0/mesh/ >> >-#aggregated_ogmsdistributed_arp_table gw_sel_class >> >orig_interval >> >-#ap_isolation fragmentation hop_penalty routing_algo >> >-#bondinggw_bandwidth isolation_mark vlan0 >> >-#bridge_loop_avoidance gw_modelog_level >> >+# aggregated_ogmsfragmentation isolation_mark routing_algo >> >+# ap_isolation gw_bandwidth log_level vlan0 >> >+# bondinggw_modemulticast_mode >> >+# bridge_loop_avoidance gw_sel_class network_coding >> >+# distributed_arp_table hop_penaltyorig_interval >> >> I strongly believe it is a huge mistake to use sysfs for things like >> this. This should be done via generic netlink api. > >This doesn't change the problem that it is already that way. This patch >only adds the list of available files to the README. Sure. Just found out you did it like that. Therefore I commented. I suggest to rework the api to use genl entirely. > >Kind regards, > Sven
Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README
On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: [...] > >--- a/Documentation/networking/batman-adv.txt > >+++ b/Documentation/networking/batman-adv.txt > >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own > >interface > > folder: > > > > # ls /sys/class/net/bat0/mesh/ > >-#aggregated_ogmsdistributed_arp_table gw_sel_classorig_interval > >-#ap_isolation fragmentation hop_penalty routing_algo > >-#bondinggw_bandwidth isolation_mark vlan0 > >-#bridge_loop_avoidance gw_modelog_level > >+# aggregated_ogmsfragmentation isolation_mark routing_algo > >+# ap_isolation gw_bandwidth log_level vlan0 > >+# bondinggw_modemulticast_mode > >+# bridge_loop_avoidance gw_sel_class network_coding > >+# distributed_arp_table hop_penaltyorig_interval > > I strongly believe it is a huge mistake to use sysfs for things like > this. This should be done via generic netlink api. This doesn't change the problem that it is already that way. This patch only adds the list of available files to the README. Kind regards, Sven signature.asc Description: This is a digitally signed message part.
Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README
Thu, Oct 27, 2016 at 09:01:36PM CEST, s...@simonwunderlich.de wrote: >From: Sven Eckelmann > >Signed-off-by: Sven Eckelmann >Signed-off-by: Simon Wunderlich >--- > Documentation/networking/batman-adv.txt | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/Documentation/networking/batman-adv.txt >b/Documentation/networking/batman-adv.txt >index d414e60..8afa991 100644 >--- a/Documentation/networking/batman-adv.txt >+++ b/Documentation/networking/batman-adv.txt >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own >interface > folder: > > # ls /sys/class/net/bat0/mesh/ >-#aggregated_ogmsdistributed_arp_table gw_sel_classorig_interval >-#ap_isolation fragmentation hop_penalty routing_algo >-#bondinggw_bandwidth isolation_mark vlan0 >-#bridge_loop_avoidance gw_modelog_level >+# aggregated_ogmsfragmentation isolation_mark routing_algo >+# ap_isolation gw_bandwidth log_level vlan0 >+# bondinggw_modemulticast_mode >+# bridge_loop_avoidance gw_sel_class network_coding >+# distributed_arp_table hop_penaltyorig_interval I strongly believe it is a huge mistake to use sysfs for things like this. This should be done via generic netlink api. >