Re: [PATCH 06/21] e1000: add smart power down code

2006-06-27 Thread Auke Kok

Jeff Garzik wrote:

Kok, Auke wrote:

Smart Power Down is a power saving feature in newer e1000 hardware. We
disable it because it causes time to link to be long, but make it a
user choice.

Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---

 drivers/net/e1000/e1000.h   |1 +
 drivers/net/e1000/e1000_main.c  |   15 +++
 drivers/net/e1000/e1000_param.c |   25 +
 3 files changed, 41 insertions(+), 0 deletions(-)


Since it's not default, who will actually use this?  Particularly since 
it is only a module option, and not supported through ethtool (frown).


laptop users that frequently re-connect their cables might enable this 
function since it saves battery life.


Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 06/21] e1000: add smart power down code

2006-06-27 Thread Florian Reitmeir
On Mon, 26 Jun 2006, Jeff Garzik wrote:

> Kok, Auke wrote:
> >Smart Power Down is a power saving feature in newer e1000 hardware. We
> >disable it because it causes time to link to be long, but make it a
> >user choice.
> >
> >Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
> >Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
> >---
> >
> > drivers/net/e1000/e1000.h   |1 +
> > drivers/net/e1000/e1000_main.c  |   15 +++
> > drivers/net/e1000/e1000_param.c |   25 +
> > 3 files changed, 41 insertions(+), 0 deletions(-)
> 
> Since it's not default, who will actually use this?  Particularly since 
> it is only a module option, and not supported through ethtool (frown).
i would use it, i always wanted the feature on my laptop (ibm thinkpad)

-- 
Florian Reitmeir
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 06/21] e1000: add smart power down code

2006-06-26 Thread Jeff Garzik

Kok, Auke wrote:

Smart Power Down is a power saving feature in newer e1000 hardware. We
disable it because it causes time to link to be long, but make it a
user choice.

Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---

 drivers/net/e1000/e1000.h   |1 +
 drivers/net/e1000/e1000_main.c  |   15 +++
 drivers/net/e1000/e1000_param.c |   25 +
 3 files changed, 41 insertions(+), 0 deletions(-)


Since it's not default, who will actually use this?  Particularly since 
it is only a module option, and not supported through ethtool (frown).


Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html