Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
From: David Miller <[EMAIL PROTECTED]> Date: Thu, 08 Jun 2006 23:40:03 -0700 (PDT) > From: Xiaolan Zhang <[EMAIL PROTECTED]> > Date: Tue, 6 Jun 2006 10:55:58 -0400 > > > Singned-off-by: Catherine Zhang <[EMAIL PROTECTED]> > > > > James, is this enough or do I need to modify the original patch to add the > > above line? The code was taken from various pieces of patches originally > > from Trent and merged/modified by me. Let me know what else I need to do. > > That's good enough for me, patch applied, thanks a lot. BTW, can I ask you SELINUX folks to at least attempt to do a build with SELINUX disabled when you submit networking changes to me? It would save me a lot of time, this one failed with: net/xfrm/xfrm_user.c: In function $,1rx(Bxfrm_del_sa$,1ry(B: net/xfrm/xfrm_user.c:430: warning: passing argument 1 of $,1rx(Bsecurity_xfrm_state_delete$,1ry(B from incompatible pointer type net/xfrm/xfrm_user.c:430: warning: suggest parentheses around assignment used as truth value net/xfrm/xfrm_user.c: In function $,1rx(Bxfrm_get_policy$,1ry(B: net/xfrm/xfrm_user.c:1060: warning: suggest parentheses around assignment used as truth value because the nop implementation of security_xfrm_state_delete() was declared to take an xfrm_policy instead of an xfrm_state. I've fixed all of this up, but please test this stuff out next time around. Thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
From: Xiaolan Zhang <[EMAIL PROTECTED]> Date: Tue, 6 Jun 2006 10:55:58 -0400 > Singned-off-by: Catherine Zhang <[EMAIL PROTECTED]> > > James, is this enough or do I need to modify the original patch to add the > above line? The code was taken from various pieces of patches originally > from Trent and merged/modified by me. Let me know what else I need to do. That's good enough for me, patch applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
Singned-off-by: Catherine Zhang <[EMAIL PROTECTED]> James, is this enough or do I need to modify the original patch to add the above line? The code was taken from various pieces of patches originally from Trent and merged/modified by me. Let me know what else I need to do. thanks, Catherine James Morris <[EMAIL PROTECTED]> wrote on 06/06/2006 01:37:04 AM: > On Tue, 6 Jun 2006, Catherine Zhang wrote: > > > Minor fix per James' comment. > > Can you also add a Signed-off-by line? > > I can't recall if you were the original author. If not, we also need a > From line (per Documentation/SubmittingPatches). > > > Thanks, > > -- > James Morris > <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
From: James Morris <[EMAIL PROTECTED]> Date: Tue, 6 Jun 2006 01:37:04 -0400 (EDT) > On Tue, 6 Jun 2006, Catherine Zhang wrote: > > > Minor fix per James' comment. > > Can you also add a Signed-off-by line? > > I can't recall if you were the original author. If not, we also need a > From line (per Documentation/SubmittingPatches). I'll apply this to my net-2.6.18 tree once this is all sorted out. Thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
On Tue, 6 Jun 2006, Catherine Zhang wrote: > Minor fix per James' comment. Can you also add a Signed-off-by line? I can't recall if you were the original author. If not, we also need a >From line (per Documentation/SubmittingPatches). Thanks, -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] LSM-IPsec SELinux Authorize (with minor fix)
On Tue, 6 Jun 2006, Catherine Zhang wrote: > Minor fix per James' comment. Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
