Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator

[David Miller]

From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 21 Jan 2008 00:46:59 +0100

I like the technique you used to fix this bug, but:

 diff -Nurp 2.6.24-rc8-mm1-/include/linux/gen_stats.h 
 2.6.24-rc8-mm1+/include/linux/gen_stats.h
 --- 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2007-10-09 22:31:38.0 
 +0200
 +++ 2.6.24-rc8-mm1+/include/linux/gen_stats.h 2008-01-20 20:37:08.0 
 +0100
 @@ -28,11 +28,13 @@ struct gnet_stats_basic
   * struct gnet_stats_rate_est - rate estimator
   * @bps: current byte rate
   * @pps: current packet rate
 + * @gen_estimator: internal data
   */
  struct gnet_stats_rate_est
  {
   __u32   bps;
   __u32   pps;
 + unsigned long   gen_estimator;
  };
  
  /**

Sorry, this structure is exported to userspace so we can't
change it like that.

It is an attribute passed over netlink sockets.

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator

[Jarek Poplawski]

On Mon, Jan 21, 2008 at 02:35:15AM -0800, David Miller wrote:
...
 Sorry, this structure is exported to userspace so we can't
 change it like that.
 
 It is an attribute passed over netlink sockets.
 

Thanks for finding this! I'll try to rethink this (especially why
my tests seemed to show something could be working there...).

Jarek P.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html