Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 04:50:05 -0800), Divy Le Ray <[EMAIL PROTECTED]> says: > > Even if you remove them, PLEASE DO NOT CHANGE THE VALUES, > > unless you have very, very good reason. : > The cxgb3 driver has not yet appeared in a stable version of the linux > kernel. > The odds of breaking an application using these private ioctls are > pretty slim. > Since some cleanup was required, I chose not to let holes between the > values. Even so, if I were you, I would not have changed them and I would even try keeping compatibility with old (out-kernel) drivers. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
YOSHIFUJI Hideaki / [EMAIL PROTECTED] wrote: In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 04:34:34 -0800), Divy Le Ray <[EMAIL PROTECTED]> says: 1. Please do do change the values. 2. Explain why you are going to kill these ioctls. Jeff and Arjan have required that most of these ioctls go. Please read: http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2 Even if you remove them, PLEASE DO NOT CHANGE THE VALUES, unless you have very, very good reason. The cxgb3 driver has not yet appeared in a stable version of the linux kernel. The odds of breaking an application using these private ioctls are pretty slim. Since some cleanup was required, I chose not to let holes between the values. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 04:34:34 -0800), Divy Le Ray <[EMAIL PROTECTED]> says: > > 1. Please do do change the values. > > 2. Explain why you are going to kill these ioctls. > > > Jeff and Arjan have required that most of these ioctls go. > Please read: > http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2 Even if you remove them, PLEASE DO NOT CHANGE THE VALUES, unless you have very, very good reason. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
Hi Yoshfuji,
From: Divy Le Ray <[EMAIL PROTECTED]>
Clean up some private ioctls.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/cxgb3_ioctl.h | 21 -
drivers/net/cxgb3/cxgb3_main.c | 48 +++
2 files changed, 9 insertions(+), 60 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
index a942818..42d4bf6 100644
--- a/drivers/net/cxgb3/cxgb3_ioctl.h
+++ b/drivers/net/cxgb3/cxgb3_ioctl.h
@@ -36,28 +36,17 @@
* Ioctl commands specific to this driver.
*/
enum {
- CHELSIO_SETREG = 1024,
- CHELSIO_GETREG,
- CHELSIO_SETTPI,
- CHELSIO_GETTPI,
- CHELSIO_GETMTUTAB,
+ CHELSIO_GETMTUTAB = 1024,
CHELSIO_SETMTUTAB,
- CHELSIO_GETMTU,
- CHELSIO_SET_PM,
- CHELSIO_GET_PM,
- CHELSIO_GET_TCAM,
- CHELSIO_SET_TCAM,
- CHELSIO_GET_TCB,
CHELSIO_GET_MEM,
CHELSIO_LOAD_FW,
- CHELSIO_GET_PROTO,
- CHELSIO_SET_PROTO,
CHELSIO_SET_TRACE_FILTER,
- CHELSIO_SET_QSET_PARAMS,
CHELSIO_GET_QSET_PARAMS,
- CHELSIO_SET_QSET_NUM,
+ CHELSIO_SET_QSET_PARAMS,
CHELSIO_GET_QSET_NUM,
- CHELSIO_SET_PKTSCHED,
+ CHELSIO_SET_QSET_NUM,
+ CHELSIO_GET_PM,
+ CHELSIO_SET_PM,
};
I disagree. This is very bad.
1. Please do do change the values.
2. Explain why you are going to kill these ioctls.
Jeff and Arjan have required that most of these ioctls go.
Please read:
http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2
Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] cxgb3 - private ioctl cleanup
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 03:59:25 -0800), [EMAIL
PROTECTED] says:
> From: Divy Le Ray <[EMAIL PROTECTED]>
>
> Clean up some private ioctls.
>
> Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
> ---
>
> drivers/net/cxgb3/cxgb3_ioctl.h | 21 -
> drivers/net/cxgb3/cxgb3_main.c | 48
> +++
> 2 files changed, 9 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
> index a942818..42d4bf6 100644
> --- a/drivers/net/cxgb3/cxgb3_ioctl.h
> +++ b/drivers/net/cxgb3/cxgb3_ioctl.h
> @@ -36,28 +36,17 @@
> * Ioctl commands specific to this driver.
> */
> enum {
> - CHELSIO_SETREG = 1024,
> - CHELSIO_GETREG,
> - CHELSIO_SETTPI,
> - CHELSIO_GETTPI,
> - CHELSIO_GETMTUTAB,
> + CHELSIO_GETMTUTAB = 1024,
> CHELSIO_SETMTUTAB,
> - CHELSIO_GETMTU,
> - CHELSIO_SET_PM,
> - CHELSIO_GET_PM,
> - CHELSIO_GET_TCAM,
> - CHELSIO_SET_TCAM,
> - CHELSIO_GET_TCB,
> CHELSIO_GET_MEM,
> CHELSIO_LOAD_FW,
> - CHELSIO_GET_PROTO,
> - CHELSIO_SET_PROTO,
> CHELSIO_SET_TRACE_FILTER,
> - CHELSIO_SET_QSET_PARAMS,
> CHELSIO_GET_QSET_PARAMS,
> - CHELSIO_SET_QSET_NUM,
> + CHELSIO_SET_QSET_PARAMS,
> CHELSIO_GET_QSET_NUM,
> - CHELSIO_SET_PKTSCHED,
> + CHELSIO_SET_QSET_NUM,
> + CHELSIO_GET_PM,
> + CHELSIO_SET_PM,
> };
>
I disagree. This is very bad.
1. Please do do change the values.
2. Explain why you are going to kill these ioctls.
Regards,
--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
