Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-19 Thread lipeng (Y) 



On 2017/12/20 3:18, David Miller wrote:

From: Lipeng 
Date: Tue, 19 Dec 2017 12:02:24 +0800


@@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv 
*priv)
return ret;
  }
  
+static void hns3_put_ring_config(struct hns3_nic_priv *priv)

+{
+   struct hnae3_handle *h = priv->ae_handle;
+   u16 i;
+
+   for (i = 0; i < h->kinfo.num_tqps; i++) {

Please use a plain "int" for index iteration loops like this since
that is the canonical type to use.

will check and fix this , Thanks.

+static void hclge_release_tqp(struct hclge_vport *vport)
+{
+   struct hnae3_knic_private_info *kinfo = >nic.kinfo;
+   struct hclge_dev *hdev = vport->back;
+   u16 i;
+
+   for (i = 0; i < kinfo->num_tqps; i++) {

Likewise.

.

Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

2017-12-19 Thread David Miller 
From: Lipeng 
Date: Tue, 19 Dec 2017 12:02:24 +0800

> @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv 
> *priv)
>   return ret;
>  }
>  
> +static void hns3_put_ring_config(struct hns3_nic_priv *priv)
> +{
> + struct hnae3_handle *h = priv->ae_handle;
> + u16 i;
> +
> + for (i = 0; i < h->kinfo.num_tqps; i++) {

Please use a plain "int" for index iteration loops like this since
that is the canonical type to use.

> +static void hclge_release_tqp(struct hclge_vport *vport)
> +{
> + struct hnae3_knic_private_info *kinfo = >nic.kinfo;
> + struct hclge_dev *hdev = vport->back;
> + u16 i;
> +
> + for (i = 0; i < kinfo->num_tqps; i++) {

Likewise.