Re: [PATCH iproute2] bpf: indicate lderr when bpf_apply_relo_data fails

2017-06-27 Thread Daniel Borkmann 

On 06/28/2017 01:09 AM, Stephen Hemminger wrote:

On Tue, 27 Jun 2017 02:48:36 +0200
Daniel Borkmann  wrote:


When LLVM wrongly generates a rodata relo entry (llvm BZ #33599),
then just bail out instead of probing for prog w/o reloc, which
will fail in this case anyway.

Signed-off-by: Daniel Borkmann 


Applied, but don't you want a reasonable error message.


Thanks, the error message in this case throws:

ELF contains non-map related relo data in entry  pointing to section ! 
Compiler bug?!

Re: [PATCH iproute2] bpf: indicate lderr when bpf_apply_relo_data fails

2017-06-27 Thread Stephen Hemminger 
On Tue, 27 Jun 2017 02:48:36 +0200
Daniel Borkmann  wrote:

> When LLVM wrongly generates a rodata relo entry (llvm BZ #33599),
> then just bail out instead of probing for prog w/o reloc, which
> will fail in this case anyway.
> 
> Signed-off-by: Daniel Borkmann 

Applied, but don't you want a reasonable error message.