Re: [PATCH mlx5-next 4/4] net/mlx5: Move flow counters data structures from flow steering header
On Tue, 2018-12-04 at 21:04 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 6:05 PM Saeed Mahameed
> wrote:
> > After the following flow counters API refactoring:
> > ("net/mlx5: Use flow counter IDs and not the wrapping cache
> > object")
> > flow counters private data structures mlx5_fc_cache and mlx5_fc are
> > redundantly exposed in fs_core.h, they have nothing to do with flow
> > steering core and they are private to fs_counter.c, this patch
> > moves them
> > to where they belong and reduces their exposure in the driver.
> >
> > Signed-off-by: Saeed Mahameed
> > ---
> > .../net/ethernet/mellanox/mlx5/core/fs_core.h | 23 -
> > --
> > .../ethernet/mellanox/mlx5/core/fs_counters.c | 23
> > +++
>
> The #include can be moved together too.
sure will do that in V2
thanks Cong!
Re: [PATCH mlx5-next 4/4] net/mlx5: Move flow counters data structures from flow steering header
On Tue, Dec 4, 2018 at 6:05 PM Saeed Mahameed wrote:
>
> After the following flow counters API refactoring:
> ("net/mlx5: Use flow counter IDs and not the wrapping cache object")
> flow counters private data structures mlx5_fc_cache and mlx5_fc are
> redundantly exposed in fs_core.h, they have nothing to do with flow
> steering core and they are private to fs_counter.c, this patch moves them
> to where they belong and reduces their exposure in the driver.
>
> Signed-off-by: Saeed Mahameed
> ---
> .../net/ethernet/mellanox/mlx5/core/fs_core.h | 23 ---
> .../ethernet/mellanox/mlx5/core/fs_counters.c | 23 +++
The #include can be moved together too.
