Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock
From: f...@ikuai8.com Date: Fri, 17 Feb 2017 14:34:19 +0800 > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one could access the qdisc_stab_list at > the same time. Then it is unnecessary to use qdisc_stab_lock now. > > Signed-off-by: Gao Feng Applied, thank you.
Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock
On Fri, 2017-02-17 at 10:02 -0800, Cong Wang wrote: > On Thu, Feb 16, 2017 at 10:34 PM, wrote: > > From: Gao Feng > > > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > > These two functions are invoked in qdisc_create, qdisc_change, and > > qdisc_destroy which run fully under RTNL. > > > > So it already makes sure only one could access the qdisc_stab_list at > > the same time. Then it is unnecessary to use qdisc_stab_lock now. > > I posted a (almost) same patch two years ago: > http://marc.info/?l=linux-netdev&m=141512383516640&w=2 > > Forget why it was not accepted at that time. Probably because you sent a huge patch serie, and I was not willing to spend a full day reviewing it. Sorry.
Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock
On Fri, 2017-02-17 at 14:34 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one could access the qdisc_stab_list at > the same time. Then it is unnecessary to use qdisc_stab_lock now. > > Signed-off-by: Gao Feng > --- Acked-by: Eric Dumazet
Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock
On Thu, Feb 16, 2017 at 10:34 PM, wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already makes sure only one could access the qdisc_stab_list at > the same time. Then it is unnecessary to use qdisc_stab_lock now. I posted a (almost) same patch two years ago: http://marc.info/?l=linux-netdev&m=141512383516640&w=2 Forget why it was not accepted at that time.
