Re: [PATCH net-next 1/1] tc-testing: Correct compound statements for namespace execution

[David Miller]

From: Lucas Bates 
Date: Mon, 26 Mar 2018 10:46:14 -0400

> If tdc is executing test cases inside a namespace, only the
> first command in a compound statement will be executed inside
> the namespace by tdc. As a result, the subsequent commands
> are not executed inside the namespace and the test will fail.
> 
> Example:
> 
> for i in {x..y}; do args="foo"; done && tc actions add $args
> 
> The namespace execution feature will prepend 'ip netns exec'
> to the command:
> 
> ip netns exec tcut for i in {x..y}; do args="foo"; done && \
>   tc actions add $args
> 
> So the actual tc command is not parsed by the shell as being
> part of the namespace execution.
> 
> Enclosing these compound statements inside a bash invocation
> with proper escape characters resolves the problem by creating
> a subshell inside the namespace.
> 
> Signed-off-by: Lucas Bates 

Applied, thank you.

Re: [PATCH net-next 1/1] tc-testing: Correct compound statements for namespace execution

[David Miller]

From: Lucas Bates 
Date: Thu, 22 Mar 2018 15:14:58 -0400

> On Thu, Mar 22, 2018 at 2:48 PM, David Miller  wrote:
>> From: Lucas Bates 
>> Date: Wed, 21 Mar 2018 11:49:40 -0400
>>
>>>  }
>>> -]
>>> \ No newline at end of file
>>> +]
>>> --
>>> 2.7.4
>>
>> Please fix this.
> 
> This patch fixes the gact.json file that had no newline on the end.

Sorry about that, please repost.

Thank you.

Re: [PATCH net-next 1/1] tc-testing: Correct compound statements for namespace execution

[Lucas Bates]

On Thu, Mar 22, 2018 at 2:48 PM, David Miller  wrote:
> From: Lucas Bates 
> Date: Wed, 21 Mar 2018 11:49:40 -0400
>
>>  }
>> -]
>> \ No newline at end of file
>> +]
>> --
>> 2.7.4
>
> Please fix this.

This patch fixes the gact.json file that had no newline on the end.

Re: [PATCH net-next 1/1] tc-testing: Correct compound statements for namespace execution

[David Miller]

From: Lucas Bates 
Date: Wed, 21 Mar 2018 11:49:40 -0400

>  }
> -]
> \ No newline at end of file
> +]
> --
> 2.7.4

Please fix this.