Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument
On 07/13/15 at 05:39pm, Tom Herbert wrote: Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on the same table. Signed-off-by: Tom Herbert t...@herbertland.com Does this preserve the inlining guarantee? I remember Herbert had to write this carefully in order to avoid indirect calls. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument
On Tue, Jul 14, 2015 at 2:44 AM, Thomas Graf tg...@suug.ch wrote: On 07/13/15 at 05:39pm, Tom Herbert wrote: Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on the same table. Signed-off-by: Tom Herbert t...@herbertland.com Does this preserve the inlining guarantee? I remember Herbert had to write this carefully in order to avoid indirect calls. It looks like the compare functions are still being properly inlined. This is gcc 4.4.7. Thanks, Tom -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html