From: Sudarsana Reddy Kalluru <sudarsana.kall...@cavium.com> Date: Thu, 22 Nov 2018 22:44:49 -0800
> - edev->flags |= QEDE_FLAG_IS_VF; > + set_bit(QEDE_FLAGS_IS_VF, &edev->flags); ... > - edev->flags |= QEDE_TX_TIMESTAMPING_EN; > + set_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, &edev->flags); ... > - edev->flags &= ~QEDE_TX_TIMESTAMPING_EN; > + clear_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, &edev->flags); Unless these operations need to be atomic, use __set_bit and __clear_bit.