Re: [PATCH net-next V3 5/7] net/sched: cls_matchall: Reflect HW offloading status

2017-02-15 Thread Or Gerlitz 
On Wed, Feb 15, 2017 at 8:15 PM, David Miller  wrote:
> From: Or Gerlitz 
> Date: Wed, 15 Feb 2017 10:52:35 +0200
>
>> @@ -194,6 +199,9 @@ static int mall_change(struct net *net, struct sk_buff 
>> *in_skb,
>>   }
>>   }
>>
>> + if (!(tc_in_hw(new->flags)))
>> + new->flags |= TCA_CLS_FLAGS_NOT_IN_HW;
>
> Too many parenthesis, please make this:
>
> if (!tc_in_hw(new->flags))
> new->flags |= TCA_CLS_FLAGS_NOT_IN_HW;

OKay, Dave, I will fix that along with the other places

Re: [PATCH net-next V3 5/7] net/sched: cls_matchall: Reflect HW offloading status

2017-02-15 Thread David Miller 
From: Or Gerlitz 
Date: Wed, 15 Feb 2017 10:52:35 +0200

> @@ -194,6 +199,9 @@ static int mall_change(struct net *net, struct sk_buff 
> *in_skb,
>   }
>   }
>  
> + if (!(tc_in_hw(new->flags)))
> + new->flags |= TCA_CLS_FLAGS_NOT_IN_HW;

Too many parenthesis, please make this:

if (!tc_in_hw(new->flags))
new->flags |= TCA_CLS_FLAGS_NOT_IN_HW;

Thanks.