Re: [PATCH net-next v2 1/4] packet: add classic BPF fanout mode

2015-08-17 Thread Eric Dumazet
On Fri, 2015-08-14 at 22:31 -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn 
> 
> Add fanout mode PACKET_FANOUT_CBPF that accepts a classic BPF program
> to select a socket.
> 
> This avoids having to keep adding special case fanout modes. One
> example use case is application layer load balancing. The QUIC
> protocol, for instance, encodes a connection ID in UDP payload.
> 
> Also add socket option SOL_PACKET/PACKET_FANOUT_DATA that updates data
> associated with the socket group. Fanout mode PACKET_FANOUT_CBPF is the
> only user so far.
> 
> Signed-off-by: Willem de Bruijn 
> ---

Oops, this was the patch I meant to approve

Acked-by: Eric Dumazet 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH net-next v2 1/4] packet: add classic BPF fanout mode

2015-08-16 Thread Daniel Borkmann

On 08/15/2015 04:31 AM, Willem de Bruijn wrote:

From: Willem de Bruijn 

Add fanout mode PACKET_FANOUT_CBPF that accepts a classic BPF program
to select a socket.

This avoids having to keep adding special case fanout modes. One
example use case is application layer load balancing. The QUIC
protocol, for instance, encodes a connection ID in UDP payload.

Also add socket option SOL_PACKET/PACKET_FANOUT_DATA that updates data
associated with the socket group. Fanout mode PACKET_FANOUT_CBPF is the
only user so far.

Signed-off-by: Willem de Bruijn 


Patch looks good to me as well (sorry for the lag, on travel).

Thanks Willem!

Acked-by: Daniel Borkmann 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH net-next v2 1/4] packet: add classic BPF fanout mode

2015-08-15 Thread Alexei Starovoitov

On 8/14/15 7:31 PM, Willem de Bruijn wrote:

From: Willem de Bruijn

Add fanout mode PACKET_FANOUT_CBPF that accepts a classic BPF program
to select a socket.

This avoids having to keep adding special case fanout modes. One
example use case is application layer load balancing. The QUIC
protocol, for instance, encodes a connection ID in UDP payload.

Also add socket option SOL_PACKET/PACKET_FANOUT_DATA that updates data
associated with the socket group. Fanout mode PACKET_FANOUT_CBPF is the
only user so far.

Signed-off-by: Willem de Bruijn


bpf bits looks good.
Acked-by: Alexei Starovoitov 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html