Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-20 Thread David Miller 
From: Andy Shevchenko 
Date: Tue, 19 Dec 2017 20:31:03 +0200

> Replace sscanf() with mac_pton().
> 
> Signed-off-by: Andy Shevchenko 

Applied to net-next.

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap 
On 12/19/2017 11:27 AM, Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote:
>> On 12/19/2017 10:31 AM, Andy Shevchenko wrote:
>>> Replace sscanf() with mac_pton().
>>>
>>> Signed-off-by: Andy Shevchenko 
>>
>> You don't need to select GENERIC_NET_UTILS for that?
> 
> It's done by CONFIG_NET.
> 

Ah, thanks.

-- 
~Randy

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Andy Shevchenko 
On Tue, 2017-12-19 at 11:19 -0800, Randy Dunlap wrote:
> On 12/19/2017 10:31 AM, Andy Shevchenko wrote:
> > Replace sscanf() with mac_pton().
> > 
> > Signed-off-by: Andy Shevchenko 
> 
> You don't need to select GENERIC_NET_UTILS for that?

It's done by CONFIG_NET.

> 
> > ---
> >  drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c
> > b/drivers/net/ethernet/pasemi/pasemi_mac.c
> > index c9a55b774935..07a2eb3781b1 100644
> > --- a/drivers/net/ethernet/pasemi/pasemi_mac.c
> > +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c
> > @@ -212,9 +212,7 @@ static int pasemi_get_mac_addr(struct pasemi_mac
> > *mac)
> > return -ENOENT;
> > }
> >  
> > -   if (sscanf(maddr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> > -  &addr[0], &addr[1], &addr[2], &addr[3],
> > &addr[4], &addr[5])
> > -   != ETH_ALEN) {
> > +   if (!mac_pton(maddr, addr)) {
> > dev_warn(&pdev->dev,
> >  "can't parse mac address, not
> > configuring\n");
> > return -EINVAL;
> > 
> 
> 

-- 
Andy Shevchenko 
Intel Finland Oy

Re: [PATCH v1] net: pasemi: Replace mac address parsing

2017-12-19 Thread Randy Dunlap 
On 12/19/2017 10:31 AM, Andy Shevchenko wrote:
> Replace sscanf() with mac_pton().
> 
> Signed-off-by: Andy Shevchenko 

You don't need to select GENERIC_NET_UTILS for that?

> ---
>  drivers/net/ethernet/pasemi/pasemi_mac.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c 
> b/drivers/net/ethernet/pasemi/pasemi_mac.c
> index c9a55b774935..07a2eb3781b1 100644
> --- a/drivers/net/ethernet/pasemi/pasemi_mac.c
> +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c
> @@ -212,9 +212,7 @@ static int pasemi_get_mac_addr(struct pasemi_mac *mac)
>   return -ENOENT;
>   }
>  
> - if (sscanf(maddr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> -&addr[0], &addr[1], &addr[2], &addr[3], &addr[4], &addr[5])
> - != ETH_ALEN) {
> + if (!mac_pton(maddr, addr)) {
>   dev_warn(&pdev->dev,
>"can't parse mac address, not configuring\n");
>   return -EINVAL;
> 


-- 
~Randy