Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
On Thursday, September 1, 2016 10:37:31 PM CEST David Miller wrote: > From: Kevin Hilman > Date: Thu, 01 Sep 2016 21:23:52 -0700 > > David Miller writes: > >> From: Martin Blumenstingl > >> Date: Tue, 30 Aug 2016 20:49:28 +0200 > >>> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: > From: Martin Blumenstingl > >>> I think patches 1, 3 and 4 should go through the net-next tree (as > >>> these touch drivers/net/ethernet/stmicro/stmmac/ and the corresponding > >>> documentation). > >>> Patch 2 should probably go through clk-meson-gxbb / clk-next (just > >>> like the other clk changes we had). > >>> The last patch (patch 5) should probably go through the ARM SoC tree > >>> (just like the other dts changes we had). > >>> > >>> @David, Kevin: would this be fine for you? > >> > >> I would prefer if all of the patches went through one tree, that way > >> all the dependencies are satisfied in one place. > > > > David, with your ack on the drivers/net changes, I can take them through > > my tree for Amlogic SoCs (which then goes via the arm-soc tree.) > > Acked-by: David S. Miller Thanks! Note that we (in arm-soc) normally put drivers and DT changes into separate branches and send a pull request for each branch separately (though usually on the same day). We expect there to be no runtime dependency between the DT changes and the driver changes other than requiring both to make use of the added features. Kevin/Martin: in case this one does have a runtime dependency, please we can put both halves into the next/drivers branch in the correct order to ensure that they are applied together, and describe the dependency in the cover letter for the pull request. Arnd
Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
From: Kevin Hilman Date: Thu, 01 Sep 2016 21:23:52 -0700 > David Miller writes: > >> From: Martin Blumenstingl >> Date: Tue, 30 Aug 2016 20:49:28 +0200 >> >>> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: From: Martin Blumenstingl Date: Sun, 28 Aug 2016 18:16:32 +0200 > This adds a DWMAC glue driver for the PRG_ETHERNET registers found in > Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver > the register layout is completely different. > Thus I introduced a separate driver. > > Changes since v2: > - fixed unloading the glue driver when built as module. This pulls in a > patch from Joachim Eastwood (thanks) to get our private data structure > (bsp_priv). This doesn't apply cleanly at all to the net-next tree, so I have no idea where you expect these changes to be applied. >>> OK, maybe Kevin can me help out here as I think the patches should go >>> to various trees. >>> >>> I think patches 1, 3 and 4 should go through the net-next tree (as >>> these touch drivers/net/ethernet/stmicro/stmmac/ and the corresponding >>> documentation). >>> Patch 2 should probably go through clk-meson-gxbb / clk-next (just >>> like the other clk changes we had). >>> The last patch (patch 5) should probably go through the ARM SoC tree >>> (just like the other dts changes we had). >>> >>> @David, Kevin: would this be fine for you? >> >> I would prefer if all of the patches went through one tree, that way >> all the dependencies are satisfied in one place. > > David, with your ack on the drivers/net changes, I can take them through > my tree for Amlogic SoCs (which then goes via the arm-soc tree.) Acked-by: David S. Miller
Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
David Miller writes: > From: Martin Blumenstingl > Date: Tue, 30 Aug 2016 20:49:28 +0200 > >> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: >>> From: Martin Blumenstingl >>> Date: Sun, 28 Aug 2016 18:16:32 +0200 >>> This adds a DWMAC glue driver for the PRG_ETHERNET registers found in Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver the register layout is completely different. Thus I introduced a separate driver. Changes since v2: - fixed unloading the glue driver when built as module. This pulls in a patch from Joachim Eastwood (thanks) to get our private data structure (bsp_priv). >>> >>> This doesn't apply cleanly at all to the net-next tree, so I have >>> no idea where you expect these changes to be applied. >> OK, maybe Kevin can me help out here as I think the patches should go >> to various trees. >> >> I think patches 1, 3 and 4 should go through the net-next tree (as >> these touch drivers/net/ethernet/stmicro/stmmac/ and the corresponding >> documentation). >> Patch 2 should probably go through clk-meson-gxbb / clk-next (just >> like the other clk changes we had). >> The last patch (patch 5) should probably go through the ARM SoC tree >> (just like the other dts changes we had). >> >> @David, Kevin: would this be fine for you? > > I would prefer if all of the patches went through one tree, that way > all the dependencies are satisfied in one place. David, with your ack on the drivers/net changes, I can take them through my tree for Amlogic SoCs (which then goes via the arm-soc tree.) Note that there may be some minor tweaks yet to the clock handling based on review comments. Thanks, Kevin
Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
From: Martin Blumenstingl Date: Tue, 30 Aug 2016 20:49:28 +0200 > On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: >> From: Martin Blumenstingl >> Date: Sun, 28 Aug 2016 18:16:32 +0200 >> >>> This adds a DWMAC glue driver for the PRG_ETHERNET registers found in >>> Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver >>> the register layout is completely different. >>> Thus I introduced a separate driver. >>> >>> Changes since v2: >>> - fixed unloading the glue driver when built as module. This pulls in a >>> patch from Joachim Eastwood (thanks) to get our private data structure >>> (bsp_priv). >> >> This doesn't apply cleanly at all to the net-next tree, so I have >> no idea where you expect these changes to be applied. > OK, maybe Kevin can me help out here as I think the patches should go > to various trees. > > I think patches 1, 3 and 4 should go through the net-next tree (as > these touch drivers/net/ethernet/stmicro/stmmac/ and the corresponding > documentation). > Patch 2 should probably go through clk-meson-gxbb / clk-next (just > like the other clk changes we had). > The last patch (patch 5) should probably go through the ARM SoC tree > (just like the other dts changes we had). > > @David, Kevin: would this be fine for you? I would prefer if all of the patches went through one tree, that way all the dependencies are satisfied in one place.
Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: > From: Martin Blumenstingl > Date: Sun, 28 Aug 2016 18:16:32 +0200 > >> This adds a DWMAC glue driver for the PRG_ETHERNET registers found in >> Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver >> the register layout is completely different. >> Thus I introduced a separate driver. >> >> Changes since v2: >> - fixed unloading the glue driver when built as module. This pulls in a >> patch from Joachim Eastwood (thanks) to get our private data structure >> (bsp_priv). > > This doesn't apply cleanly at all to the net-next tree, so I have > no idea where you expect these changes to be applied. OK, maybe Kevin can me help out here as I think the patches should go to various trees. I think patches 1, 3 and 4 should go through the net-next tree (as these touch drivers/net/ethernet/stmicro/stmmac/ and the corresponding documentation). Patch 2 should probably go through clk-meson-gxbb / clk-next (just like the other clk changes we had). The last patch (patch 5) should probably go through the ARM SoC tree (just like the other dts changes we had). @David, Kevin: would this be fine for you?
Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver
From: Martin Blumenstingl Date: Sun, 28 Aug 2016 18:16:32 +0200 > This adds a DWMAC glue driver for the PRG_ETHERNET registers found in > Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver > the register layout is completely different. > Thus I introduced a separate driver. > > Changes since v2: > - fixed unloading the glue driver when built as module. This pulls in a > patch from Joachim Eastwood (thanks) to get our private data structure > (bsp_priv). This doesn't apply cleanly at all to the net-next tree, so I have no idea where you expect these changes to be applied.
