Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-12 Thread Peng Tao 
On Mon, Dec 12, 2016 at 6:37 PM, Jorgen S. Hansen  wrote:
>
>> On Dec 8, 2016, at 6:12 PM, Peng Tao  wrote:
>>
>> --- a/include/net/af_vsock.h
>> +++ b/include/net/af_vsock.h
>> @@ -100,6 +100,9 @@ struct vsock_transport {
>>   void (*destruct)(struct vsock_sock *);
>>   void (*release)(struct vsock_sock *);
>>
>> + /* Cancel packets belonging the same vsock */
>
> How about “/* Cancel all pending packets sent on vsock. */“ ?
>
Sure. I'll update it.

Thanks,
Tao

Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-12 Thread Jorgen S. Hansen 

> On Dec 8, 2016, at 6:12 PM, Peng Tao  wrote:
> 
> --- a/include/net/af_vsock.h
> +++ b/include/net/af_vsock.h
> @@ -100,6 +100,9 @@ struct vsock_transport {
>   void (*destruct)(struct vsock_sock *);
>   void (*release)(struct vsock_sock *);
> 
> + /* Cancel packets belonging the same vsock */

How about “/* Cancel all pending packets sent on vsock. */“ ? 

> + int (*cancel_pkt)(struct vsock_sock *vsk);
> +
>   /* Connections. */
>   int (*connect)(struct vsock_sock *);
> 
> -- 
> 2.7.4
> 

Thanks,
Jørgen

Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-09 Thread Stefan Hajnoczi 
On Fri, Dec 09, 2016 at 01:12:34AM +0800, Peng Tao wrote:
> To allow canceling all packets of a connection.
> 
> Reviewed-by: Stefan Hajnoczi 
> Signed-off-by: Peng Tao 
> ---
>  drivers/vhost/vsock.c  | 41 +
>  include/net/af_vsock.h |  3 +++
>  2 files changed, 44 insertions(+)
> 
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index a504e2e0..db64d51 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -218,6 +218,46 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>   return len;
>  }
>  
> +static int
> +vhost_transport_cancel_pkt(struct vsock_sock *vsk)
> +{
> + struct vhost_vsock *vsock;
> + struct virtio_vsock_pkt *pkt, *n;
> + int cnt = 0;
> + LIST_HEAD(freeme);
> +
> + /* Find the vhost_vsock according to guest context id  */
> + vsock = vhost_vsock_get(vsk->remote_addr.svm_cid);
> + if (!vsock)
> + return -ENODEV;
> +
> + spin_lock_bh(>send_pkt_list_lock);
> + list_for_each_entry_safe(pkt, n, >send_pkt_list, list) {
> + if (pkt->cancel_token != (void *)vsk)

It's not necessary to cast to void* in C.  All pointers cast to void*
automatically without compiler warnings.  The warnings and explicit
casts are a C++ thing.


signature.asc
Description: PGP signature