Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
Hello, On Mon, 20 Feb 2017 11:12:26 -0500 (EST), David Miller wrote: > For your particular case I'll accept a resubmit. Resubmit done, patches are now in patchwork. Changes since v3 (also in the cover letter of v4) : - Addition of a patch "net: mvpp2: fix DMA address calculation in mvpp2_txq_inc_put()", which fixes a bug in the driver in the calculation of DMA addresses. This bug was found using DMA_API_DEBUG. - Modify the "net: mvpp2: switch to build_skb() in the RX path" patch to recalculate the fragment size when the MTU is changed in mvpp2_bm_update_mtu(). - Added Acked-by from Russell King on all patches, except: * "net: mvpp2: fix DMA address calculation in mvpp2_txq_inc_put()", because it's a new patch * "net: mvpp2: switch to build_skb() in the RX path" because I modified it since the v3. - Rebased on top of 4.10. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
From: Thomas PetazzoniDate: Mon, 20 Feb 2017 16:47:41 +0100 > Hello, > > On Mon, 20 Feb 2017 09:53:57 -0500 (EST), David Miller wrote: > >> > This series has been on the list for a while, and has received review >> > and a Acked-by. Would it be possible to merge it? >> >> You need to repost the series if it isn't in patchwork in state >> "Under Review". > > Is net-next still open? I.e can I resend today/tomorrow? For your particular case I'll accept a resubmit.
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
Hello, On Mon, 20 Feb 2017 09:53:57 -0500 (EST), David Miller wrote: > > This series has been on the list for a while, and has received review > > and a Acked-by. Would it be possible to merge it? > > You need to repost the series if it isn't in patchwork in state > "Under Review". Is net-next still open? I.e can I resend today/tomorrow? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
From: Thomas PetazzoniDate: Mon, 20 Feb 2017 10:07:42 +0100 > David, > > On Thu, 9 Feb 2017 09:55:34 +, Russell King - ARM Linux wrote: > >> For the whole series: >> >> Acked-by: Russell King > > This series has been on the list for a while, and has received review > and a Acked-by. Would it be possible to merge it? You need to repost the series if it isn't in patchwork in state "Under Review".
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
David, On Thu, 9 Feb 2017 09:55:34 +, Russell King - ARM Linux wrote: > For the whole series: > > Acked-by: Russell KingThis series has been on the list for a while, and has received review and a Acked-by. Would it be possible to merge it? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
On Thu, Feb 02, 2017 at 04:51:29PM +0100, Thomas Petazzoni wrote: > David, > > This series contains a number of misc improvements and preparation > patches for an upcoming series that adds support for the new PPv2.2 > network controller to the mvpp2 driver. > > Sorry for the long delay since v2, I was on > vacation/conference/training in January, and therefore wasn't able to > resend a new version earlier. Upcoming versions should arrive much > faster, if there are further comments on this series. > > The most significant improvements are: > > - Switching to using build_skb(), which is necessary for the upcoming >PPv2.2 support, but anyway a good improvement to the current mvpp2 >driver (supporting PPv2.1). > > - Making the driver build on 64-bit platforms. > > Changes since v2: > > - Fix remaining 64-bit build warning, reported by David Miller. > > - Adjust how bit mask related definitions are done in "net: mvpp2: >simplify MVPP2_PRS_RI_* definitions" according to Russell King >suggestions. > > - Add a patch "net: mvpp2: remove useless arguments in >mvpp2_rx_{pkts,time}_coal_set", suggested by Russell King. > > - Rework mvpp2_rx_time_coal_set() implementation to avoid overflows >and rounding errors. I've used the implementation suggested by >Russell King. > > Changes since v1: > > - This series is split as a separate series from the larger patch set >adding support for PPv2.2 in the mvpp2 driver, as requested by >David Miller. > > - Rebased on top of v4.10-rc1. For the whole series: Acked-by: Russell KingThanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Re: [PATCHv3 net-next 00/12] net: mvpp2: misc improvements and preparation patches
David, On Thu, 2 Feb 2017 16:51:29 +0100, Thomas Petazzoni wrote: > This series contains a number of misc improvements and preparation > patches for an upcoming series that adds support for the new PPv2.2 > network controller to the mvpp2 driver. Since I haven't received any comment on this series (besides a suggestion for a possible future improvement) and the kbuild robot hasn't complained, would it be possible to get this series merged for the next merge window ? This way, we would be able to get these preliminary patches in 4.11, and then the next patch series (PPv2.2) hopefully in 4.12. Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com