Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation
applied the ethtool part of this - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation
On Fri, Aug 10, 2007 at 02:05:13PM -0700, [EMAIL PROTECTED] wrote: Also added a disable_autoneg module argument to completely disable autoneg on all cards using this driver. ... [akpm: this is a previously-nacked patch, but the problem is real] Please remove this part of the patch. The ethtool support is sufficient and doesn't clobber other cards in the system. At the very least the module parameter has to be limited to a specific card. -ben -- Time is of no importance, Mr. President, only life is important. Don't Email: [EMAIL PROTECTED]. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation
On Fri, 10 Aug 2007 17:13:49 -0400 Benjamin LaHaise [EMAIL PROTECTED] wrote: On Fri, Aug 10, 2007 at 02:05:13PM -0700, [EMAIL PROTECTED] wrote: Also added a disable_autoneg module argument to completely disable autoneg on all cards using this driver. ... [akpm: this is a previously-nacked patch, but the problem is real] Please remove this part of the patch. The ethtool support is sufficient and doesn't clobber other cards in the system. At the very least the module parameter has to be limited to a specific card. I think I'll drop the whole patch. I've been nursing the thing along for 1.5 years and I don't recall seeing any reports of any bugs which it would have fixed anyway. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
