Re: ISDN-Gigaset: Fine-tuning for three function implementations
On Wed, 2016-09-28 at 18:50 +0200, SF Markus Elfring wrote: > Would you like to look once more into an improved patch series for this > software module a bit later? I'm afraid I'm not looking forward to receiving an update of this series, sorry. Thanks, Paul Bolle
Re: ISDN-Gigaset: Fine-tuning for three function implementations
> Two of the five patches introduced bugs. The rest of the series isn't > free of various nits either. Of course, I was in no mood to be lenient > when I looked at those three patches. > > I won't take any of these patches, sorry. Would you like to look once more into an improved patch series for this software module a bit later? Regards, Markus
Re: ISDN-Gigaset: Fine-tuning for three function implementations
>> Use kmalloc_array() in two functions >> Improve another size determination in gigaset_initcs() >> Delete an error message for a failed memory allocation >> Release memory in gigaset_initcs() after an allocation failure > > Which "static source code analysis" was used for that discovery? Are you eventually asking more for the development tools which were involved here? * Coccinelle software * Script "checkpatch.pl" * My own eyes with help of a current text editor and its programming support Regards, Markus