Re: Oops in 2.6.23-rc5

[Christian Kujau]

On Sun, 2 Sep 2007, Herbert Xu wrote:

You want this patch (by davem).


I applied the patch and the box is up for 1hr now. Since I was able to 
reproduce the oops pretty reliable with this bittorrent thingy, I 
did the same a few times now, but the box did NOT crash :)



Unfortunately people are travelling so I'm not sure when it'll
get picked up by Linus.


I've seen this patch only in:
http://article.gmane.org/gmane.linux.network/70781

And, for the archives, a simliar looking error report:
http://article.gmane.org/gmane.linux.network/70777

Thanks for the quick reply, Herbert!

Christian.
--
BOFH excuse #297:

Too many interrupts
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Oops in 2.6.23-rc5

[Herbert Xu]

Christian Kujau [EMAIL PROTECTED] wrote:
 
 today I switched from 2.6.22.3 to 2.6.23-rc5 (skipped quite a few -rc 
 versions due to lack of time), and the box keeps panicking under certain 
 circumstances. I suspected disk related problems, because: when the box 
 is up, I usually resume ~10 bittorrent files. When doing this, each
 file (~200MB...1GB) is checked and disk activity is pretty high (20MB/s
 or so), and after 1 minute of doing so the box panicks. Every time.

You want this patch (by davem).

Unfortunately people are travelling so I'm not sure when it'll
get picked up by Linus.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
From: [EMAIL PROTECTED] (David Miller)

 ip is at tcp_rto_min+0x20/0x40

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 1ee7212..bbad2cd 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -560,7 +560,7 @@ static u32 tcp_rto_min(struct sock *sk)
struct dst_entry *dst = __sk_dst_get(sk);
u32 rto_min = TCP_RTO_MIN;
 
-   if (dst_metric_locked(dst, RTAX_RTO_MIN))
+   if (dst  dst_metric_locked(dst, RTAX_RTO_MIN))
rto_min = dst-metrics[RTAX_RTO_MIN-1];
return rto_min;
 }
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html