Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()

[Niklas Cassel]

On Tue, Jan 9, 2018 at 3:02 AM, David Miller  wrote:
> From: Al Viro 
> Date: Fri, 05 Jan 2018 19:31:58 +
>
>> Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
>> had been taking iomem address to access as the first argument; its
>> predecessor (->ctrl_ane()) used to take struct mac_device_info instead.
>>
>> One of the callers had not been converted; as the result, instead of
>> reading and modifying a word in card iomem we read and modify a word
>> in (or near) the in-core strucct mac_device_info.
>>
>> Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
>> Cc: sta...@vger.kernel.org
>> Signed-off-by: Al Viro 
>
> Yikes...
>
> Al, can you split the bug fixes like this one into a separate series
> for me to pull into my net GIT tree?

This looks like a nasty bug,
I haven't seen a resubmission of this.
Would be a shame if it just went forgotten.

Regards,
Niklas

Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()

[David Miller]

From: Al Viro 
Date: Fri, 05 Jan 2018 19:31:58 +

> Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane()
> had been taking iomem address to access as the first argument; its
> predecessor (->ctrl_ane()) used to take struct mac_device_info instead.
> 
> One of the callers had not been converted; as the result, instead of
> reading and modifying a word in card iomem we read and modify a word
> in (or near) the in-core strucct mac_device_info.
> 
> Fixes: 70523e639bf8 (drivers: net: stmmac: reworking the PCS code)
> Cc: sta...@vger.kernel.org
> Signed-off-by: Al Viro 

Yikes...

Al, can you split the bug fixes like this one into a separate series
for me to pull into my net GIT tree?

Don't include the pure annotation or partial endianness conversion
ones, those should go to net-next.