Re: fib_hash removal
On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace: [810956e9] debug_show_held_locks+0x9/0xb [8100b0b0] __might_sleep+0xd9/0xdb [8100f745] __kmalloc_track_caller+0x67/0x10f [810aaff1] __kzalloc+0x15/0x2f [811fc5a5] tnode_new+0x55/0x122 tnode_alloc() uses GFP_KERNEL ... [811fcc88] resize+0x616/0x966 [811d2e08] nlmsg_notify+0x43/0x6f [811fd074] trie_rebalance+0x9c/0xef [811fd231] trie_leaf_remove+0x16a/0x1c2 ... but we have preempt_disable() here. Regards, Jarek P. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fib_hash removal
Jarek Poplawski wrote: On 14-03-2007 23:49, Patrick McHardy wrote: ... I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace: [810956e9] debug_show_held_locks+0x9/0xb [8100b0b0] __might_sleep+0xd9/0xdb [8100f745] __kmalloc_track_caller+0x67/0x10f [810aaff1] __kzalloc+0x15/0x2f [811fc5a5] tnode_new+0x55/0x122 tnode_alloc() uses GFP_KERNEL ... [811fcc88] resize+0x616/0x966 [811d2e08] nlmsg_notify+0x43/0x6f [811fd074] trie_rebalance+0x9c/0xef [811fd231] trie_leaf_remove+0x16a/0x1c2 ... but we have preempt_disable() here. Yes, Robert already sent me a patch to remove the bogus preempt_disable, but IIRC it was there to make sure changes to the tree don't interfere with packet processing, so we might need to do something else. I'll try to look into it later today. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fib_hash removal
On Thu, Mar 15, 2007 at 08:43:59AM +0100, Patrick McHardy wrote: ... On 14-03-2007 23:49, Patrick McHardy wrote: ... BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 ... Yes, Robert already sent me a patch to remove the bogus preempt_disable, but IIRC it was there to make sure changes to the tree don't interfere with packet processing, so we might need to do something else. I'll try to look into it later today. BTW: it seems fib_tree wasn't used too much, so probably, before killing fib_hash, fib_tree should be made Kconfig default for some time. Jarek P. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fib_hash removal
On Thu, Mar 15, 2007 at 10:15:44AM +0100, Jarek Poplawski wrote: ... BTW: it seems fib_tree wasn't used too much, so probably, before killing fib_hash, fib_tree should be made Kconfig default for some time. Sorry! Let fib_tree stay out of Kconfig and make fib_trie the default. Jarek P. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: fib_hash removal
David Miller wrote: Another thing I'd like to accomplish is to kill off fib_hash leaving just fib_trie. I can't do that until any and all functionality regressions which may or may not exist in fib_trie vs. fib_hash are discussed and resolved. So can we start composing a list of stuff to look into in this thread so work can begin in that area? I noticed this a couple of times, but didn't manage to look into it yet: BUG: sleeping function called from invalid context at mm/slab.c:3032 in_atomic():1, irqs_disabled():0 no locks held by ip/14309. Call Trace: [810956e9] debug_show_held_locks+0x9/0xb [8100b0b0] __might_sleep+0xd9/0xdb [8100f745] __kmalloc_track_caller+0x67/0x10f [810aaff1] __kzalloc+0x15/0x2f [811fc5a5] tnode_new+0x55/0x122 [811fcc88] resize+0x616/0x966 [811d2e08] nlmsg_notify+0x43/0x6f [811fd074] trie_rebalance+0x9c/0xef [811fd231] trie_leaf_remove+0x16a/0x1c2 [811fd7aa] fn_trie_delete+0x150/0x1fc [811f94a3] inet_rtm_delroute+0x37/0x3e [811c7237] rtnetlink_rcv_msg+0x1ba/0x1dd [811d2ee8] netlink_run_queue+0x72/0xfa [811c707d] rtnetlink_rcv_msg+0x0/0x1dd [811c7028] rtnetlink_rcv+0x32/0x50 [811d32b9] netlink_data_ready+0x1a/0x59 [811d24bf] netlink_sendskb+0x29/0x44 [811d2bf2] netlink_unicast+0x1e5/0x204 [811d328a] netlink_sendmsg+0x270/0x285 [81051215] sock_sendmsg+0xdf/0xf8 [81090aac] autoremove_wake_function+0x0/0x38 [81090aac] autoremove_wake_function+0x0/0x38 [81008b4f] __handle_mm_fault+0x5f7/0xb09 [81020ab8] __up_read+0x1a/0x83 [811b734b] move_addr_to_kernel+0x25/0x35 [811bd1a7] verify_iovec+0x4f/0x91 [811b7e4d] sys_sendmsg+0x1de/0x250 [81092d7c] up_read+0x26/0x2a [8106315f] do_page_fault+0x407/0x765 [81060cdb] _spin_unlock_irqrestore+0x4c/0x69 [8102e6e9] __up_write+0xf0/0xff [81060249] trace_hardirqs_on_thunk+0x35/0x37 [8105a11e] system_call+0x7e/0x83 Reproducable by running: for i in $(seq 0 255); do ip r a 1.$i.1.1/32 dev lo; done for i in $(seq 0 255); do ip r d 1.$i.1.1/32 dev lo; done - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
