Re: simplify configfs attributes V2
Hi Christoph & Co, On Sat, 2015-10-03 at 15:32 +0200, Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and binary size of configfs consumers a lot. > > Changes since V1: > - a couple fixes for unintended changes in the uvc driver > - moved a few CONFIG_ATTR() statements around > - fixed up the documentation and samples in the last patch > - added a little rather pointless blurb to the patch description for >various patches > Apologies for the delayed follow-up on -v2. Applied to target-pending/for-next, with Felipe's ACK for usb, and Pratyush's ACK for spear13xx. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes V2
On Mon, Oct 05, 2015 at 02:37:05PM -0700, Andrew Morton wrote: > > This series consolidates the code to implement configfs attributes > > by providing the ->show and ->store method in common code and using > > container_of in the methods to access the containing structure. > > > > This reduces source and binary size of configfs consumers a lot. > > There's a version of this patch series (I assume V1) in linux-next via > Nicholas's tree so my hands are tied. I trust that Nicholas will > update things. > > Or maybe it was a slipup - modifying usb, ocfs2 etc from the iscsi tree > is innovative ;) Nic wanted this as the target code is the biggest user of configfs. I don't really care where it goes as long as we get in the current version into a stable not to be rebased branch somehwere so that all consumers can use that as a base point. Nic, can you do that? A lot of previous work went in through Andrew, but I think -mm is still a quilt stack so the stable base branch wouldn't be possible that way. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes V2
On Fri, Oct 09, 2015 at 04:37:51PM -0500, Felipe Balbi wrote: > For reference, I'm fine if you guys take all patches through FS > tree. Another option is waiting for dependencies to be merged in v4.4, > and the gadget changes merge in v4.5, whatever works. I'd prefer to take them all in one go. If we really have to I could drop the last patch for now and clean up later, but I'd prefer not to. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes V2
Christoph Hellwig writes: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and binary size of configfs consumers a lot. > > Changes since V1: > - a couple fixes for unintended changes in the uvc driver > - moved a few CONFIG_ATTR() statements around > - fixed up the documentation and samples in the last patch > - added a little rather pointless blurb to the patch description for >various patches For reference, I'm fine if you guys take all patches through FS tree. Another option is waiting for dependencies to be merged in v4.4, and the gadget changes merge in v4.5, whatever works. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature
Re: simplify configfs attributes V2
On Sat, 3 Oct 2015 15:32:36 +0200 Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and binary size of configfs consumers a lot. There's a version of this patch series (I assume V1) in linux-next via Nicholas's tree so my hands are tied. I trust that Nicholas will update things. Or maybe it was a slipup - modifying usb, ocfs2 etc from the iscsi tree is innovative ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes
Hi Christoph, W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: This series consolidates the code to implement configfs attributes by providing the ->show and ->store method in common code and using container_of in the methods to access the containing structure. This reduces source and binary size of configfs consumers a lot. Thank you for this series. It is definitely the way to go. I reviewed it as far as the configfs consumers which I wrote or have experience with are concerned. There are some minor issues which you perhaps can call nitpicks. In the last patch (23/23) I think you meant something different when changing the documentation - please see my response to that patch. But otherwise this series is very welcome. AP -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes
On Sat, Sep 26, 2015 at 04:49:06PM -0700, Nicholas A. Bellinger wrote: > That said, it would probably make sense to merge via target-pending.git > and get this series into linux-next ASAP. Sounds good to me! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes
On Fri, 2015-09-25 at 06:49 -0700, Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and binary size of configfs consumers a lot. > Looking at the complete series, the subsystem it touches the most is target-core + fabric driver code, which is not surprising considering it's the largest consumer of configfs. That said, it would probably make sense to merge via target-pending.git and get this series into linux-next ASAP. --nab -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: simplify configfs attributes
Any I promised to Cc Pantelis when posting this for his binary attribute work but failed to do. I'm very sorry for that and blame in on the lack of sleep. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
