Repost: Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()
VLAN devices did not get registered as admin up in 2.6.16 and IMHO also not in 2.6.17. So update patch description. Ok, the following patch should fix the problem. Patrick, can you give it a try? As the bug did not affect me through my testing, I want to be sure it works now. This is stuff for 2.6.18 and 2.6.17-stable. Stefan [VLAN]: Fix link state propagation When the queue of the underlying device is stopped at initialization time or the device is marked "not present", the state will be propagated to the vlan device and never change. Based on an analysis by Patrick McHardy. Signed-off-by: Stefan Rompf <[EMAIL PROTECTED]> --- linux-2.6.17/net/8021q/vlan.c.orig 2006-07-07 13:00:56.0 +0200 +++ linux-2.6.17/net/8021q/vlan.c 2006-07-11 23:20:32.0 +0200 @@ -67,10 +67,6 @@ static struct packet_type vlan_packet_ty .func = vlan_skb_recv, /* VLAN receive method */ }; -/* Bits of netdev state that are propagated from real device to virtual */ -#define VLAN_LINK_STATE_MASK \ - ((1<<__LINK_STATE_PRESENT)|(1<<__LINK_STATE_NOCARRIER)|(1<<__LINK_STATE_DORMANT)) - /* End of global variables definitions. */ /* @@ -470,7 +466,9 @@ static struct net_device *register_vlan_ new_dev->flags = real_dev->flags; new_dev->flags &= ~IFF_UP; - new_dev->state = real_dev->state & ~(1<<__LINK_STATE_START); + new_dev->state = (real_dev->state & ((1<<__LINK_STATE_NOCARRIER) | +(1<<__LINK_STATE_DORMANT))) | +(1<<__LINK_STATE_PRESENT); /* need 4 bytes for extra VLAN header info, * hope the underlying device can handle it. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Repost: Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()
Stefan Rompf wrote: > the following patch should fix the problem. Patrick, can you give it a > try? As the bug did not affect me through my testing, I want to be sure it > works now. This is stuff for 2.6.18 and 2.6.17-stable. I'm on my way out the door and will be gone for a couple of days, so its going to take me a while. But it looks fine, if you want to test it yourself, just pull the ethernet cable before adding a VLAN and plug it in again afterwards. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Repost: Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()
Stefan Rompf wrote: > VLAN devices did not get registered as admin up in 2.6.16 and IMHO also > not in 2.6.17. So update patch description. > > Ok, > > the following patch should fix the problem. Patrick, can you give it a > try? As the bug did not affect me through my testing, I want to be sure it > works now. This is stuff for 2.6.18 and 2.6.17-stable. Sorry for the delay. Just tested by unplugging the cable from eth0, adding a bunch of VLANs and plugging the cable again, everything works fine. > [VLAN]: Fix link state propagation > > When the queue of the underlying device is stopped at initialization time > or the device is marked "not present", the state will be propagated to the > vlan device and never change. Based on an analysis by Patrick McHardy. ACKed-by: Patrick McHardy <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Repost: Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 19 Jul 2006 14:42:35 +0200 > Stefan Rompf wrote: > > [VLAN]: Fix link state propagation > > > > When the queue of the underlying device is stopped at initialization time > > or the device is marked "not present", the state will be propagated to the > > vlan device and never change. Based on an analysis by Patrick McHardy. > > ACKed-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, and I will queue this up for -stable. Thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
