RE: drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ?

2016-05-23 Thread Yuval Mintz 
> Hello there,
> 
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210:16: warning: comparison is
> always false due to limited range of data type [-Wtype-limits]
> 
> Source code is
> 
>if (priority < 0) {
> 
> but
> 
> u8 tc, priority, priority_map;
> 
> 
> Regards
> 
> David Binderman

Hi David,

Dan Carpenter has already sent a fix for this one ~an hour ago.
[https://patchwork.ozlabs.org/patch/625114/]

Thanks,
Yuval

drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ?

2016-05-23 Thread David Binderman 
Hello there,

drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210:16: warning: comparison
is always false due to limited range of data type [-Wtype-limits]

Source code is

   if (priority < 0) {

but

u8 tc, priority, priority_map;


Regards

David Binderman