linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  9cd00a8aa42e ("net: phy: phylink: Poll link GPIOs")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell


pgpi5UnW2Prac.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  cbad52e92ad7 ("sfc: don't warn on successful change of MAC")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Francois Romieu]

Kirill Smelkov  :
[...]
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

I thought it was longer than that. Sorry for the frustrating excess delay.

As Eric already said there is no problem and I am perfectly fine with
the current attribution of this code.

Use of errno.h::ELNRNG is really unusual but it's a different topic.

-- 
Ueimor

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Eric Dumazet]

On Tue, 2017-10-31 at 09:14 +0300, Kirill Smelkov wrote:
> Francois,
> 
> On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool 
> > -C)")
> > 
> > is missing a Signed-off-by from its author (or its author is wrong).
> 
> Could we please get signoff for this your patch from 2012 which I've
> reworked a bit to be commit 509708310cf9 ?
> 
>   https://www.spinics.net/lists/netdev/msg217984.html
>   https://www.spinics.net/lists/netdev/msg218207.html
> 
> I was keeping you in To and Cc all the time but got no reply at all since my
> first posting from ~ 1 month ago.

Nothing we can do, patch is merged, we can not modify it anymore.

You provided all the rationale in the changelog, so no worries.

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Kirill Smelkov]

Francois,

On Tue, Oct 31, 2017 at 04:40:19PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool 
> -C)")
> 
> is missing a Signed-off-by from its author (or its author is wrong).

Could we please get signoff for this your patch from 2012 which I've
reworked a bit to be commit 509708310cf9 ?

https://www.spinics.net/lists/netdev/msg217984.html
https://www.spinics.net/lists/netdev/msg218207.html

I was keeping you in To and Cc all the time but got no reply at all since my
first posting from ~ 1 month ago.

Thanks beforehand,
Kirill

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  509708310cf9 ("r8169: Add support for interrupt coalesce tuning (ethtool -C)")

is missing a Signed-off-by from its author (or its author is wrong).

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Miller]

From: David Ahern 
Date: Wed, 30 Aug 2017 10:53:48 -0600

> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commit
>> 
>>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local 
>> address")
>> 
>> is missing a Signed-off-by from its author.
>> 
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Yes, it unfortunately got clipped off by GIT due to how the
commit message was written. :(

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi David,

On Wed, 30 Aug 2017 10:53:48 -0600 David Ahern  wrote:
>
> On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local 
> > address")
> > 
> > is missing a Signed-off-by from its author.
> 
> Eric pointed this out last night. The commit message copied output from
> a command that contained '---' so git ignored the remainder of the message.

Rats!

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the net-next tree

[David Ahern]

On 8/30/17 10:51 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local 
> address")
> 
> is missing a Signed-off-by from its author.
> 

Eric pointed this out last night. The commit message copied output from
a command that contained '---' so git ignored the remainder of the message.

linux-next: Signed-off-by missing for commit in the net-next tree

[Stephen Rothwell]

Hi all,

Commit

  1b70d792cf67 ("ipv6: Use rt6i_idev index for echo replies to a local address")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell