Re: networking busted in current -git ???

2007-06-09 Thread Trond Myklebust 
On Fri, 2007-06-08 at 19:06 -0700, David Miller wrote:
 From: Trond Myklebust [EMAIL PROTECTED]
 Date: Fri, 08 Jun 2007 17:43:27 -0400
 
  It is not dhcp. I'm seeing the same bug with bog-standard ifup with a
  static address on an FC-6 machine.
  
  It appears to be something in the latest dump from davem to Linus, but I
  haven't yet had time to identify what.
 
 Linus's current tree should have this fixed.
 
 Let us know if this is not the case.

It appears to be working for me again.

Trond

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: networking busted in current -git ???

2007-06-08 Thread Trond Myklebust 
On Fri, 2007-06-08 at 23:07 +0200, Arkadiusz Miskiewicz wrote:
 On Friday 08 of June 2007, you wrote:
  Hello,
 
  I am using the current git tree: 85f6038f2170e3335dda09c3dfb0f83110e87019 .
  Git tree from two days ago (with the same config) works fine.
 
  Attempting to acquire an IP address via DHCP fails with:
 
  SIOCSIFADDR: No buffer space available
  Listening on LPF/eth0/00:19:b9:0c:9a:43
  Sending on   LPF/eth0/00:19:b9:0c:9a:43
  Sending on   Socket/fallback
  DHCPREQUEST on eth0 to 255.255.255.255 port 67
  DHCPACK from xxx.xxx.xxx.xxx
  SIOCSIFADDR: No buffer space available
  SIOCSIFNETMASK: Cannot assign requested address
  SIOCSIFBRDADDR: Cannot assign requested address
  SIOCADDRT: Network is unreachable
  bound to xxx.xxx.xxx.xxx -- renewal in 98610 seconds.
 
  This is on a Dell 490 with tg3 network driver running Ubuntu 7.04 .
  .config and dmesg are appended.
 
  florin
 
 Here it requires few retries (stop dhcpcd, start again) to get the IP. git 
 tree from few hours ago. tg3 driver. I also saw SIOCSIFADDR: No buffer space 
 available once.

(added netdev to the Cc list)

It is not dhcp. I'm seeing the same bug with bog-standard ifup with a
static address on an FC-6 machine.

It appears to be something in the latest dump from davem to Linus, but I
haven't yet had time to identify what.

Cheers
  Trond

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: networking busted in current -git ???

2007-06-08 Thread Herbert Xu 
Trond Myklebust [EMAIL PROTECTED] wrote:
 
 It appears to be something in the latest dump from davem to Linus, but I
 haven't yet had time to identify what.

You want this patch which should hit the tree soon.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
[IPV4]: Do not remove idev when addresses are cleared

Now that we create idev before addresses are added, it no longer makes
sense to remove them when addresses are all deleted.

Signed-off-by: Herbert Xu [EMAIL PROTECTED]

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 354e800..0cf813f 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -327,12 +327,8 @@ static void __inet_del_ifa(struct in_device *in_dev, 
struct in_ifaddr **ifap,
}
 
}
-   if (destroy) {
+   if (destroy)
inet_free_ifa(ifa1);
-
-   if (!in_dev-ifa_list)
-   inetdev_destroy(in_dev);
-   }
 }
 
 static void inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: networking busted in current -git ???

2007-06-08 Thread David Miller 
From: Trond Myklebust [EMAIL PROTECTED]
Date: Fri, 08 Jun 2007 17:43:27 -0400

 It is not dhcp. I'm seeing the same bug with bog-standard ifup with a
 static address on an FC-6 machine.
 
 It appears to be something in the latest dump from davem to Linus, but I
 haven't yet had time to identify what.

Linus's current tree should have this fixed.

Let us know if this is not the case.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html