Re: next-20160929 build: 2 failures 4 warnings (next-20160929)
On Thursday 29 September 2016, Vishwanath Pai wrote: > I have sent a patch for this a couple of days ago to netdev, it hasn't > made it to net-next yet. Here's the latest one: > > [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit > arch because of 64bit division > > This should fix the link error. I also did a patch (not submitted yet), but my solution used 32-bit math for the version 1 case. I think that would be better so we don't slow down 32-bit architectures too much (div_u64_u64 is very slow). Arnd
Re: next-20160929 build: 2 failures 4 warnings (next-20160929)
On 09/29/2016 02:47 PM, Mark Brown wrote: > On Thu, Sep 29, 2016 at 12:40:35PM +0100, Build bot for Mark Brown wrote: > > For the past couple of days -next has been failing to build an ARM > allmodconfig due to: > >> arm-allmodconfig >> ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! > > which appears to be triggered by 11d5f15723c9 (netfilter: xt_hashlimit: > Create revision 2 to support higher pps rates) introducing a division of > a 64 bit number which should be done using do_div(). > I have sent a patch for this a couple of days ago to netdev, it hasn't made it to net-next yet. Here's the latest one: [PATCH net-next v3] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division This should fix the link error. -Vishwanath
Re: next-20160929 build: 2 failures 4 warnings (next-20160929)
On Thu, Sep 29, 2016 at 12:40:35PM +0100, Build bot for Mark Brown wrote: For the past couple of days -next has been failing to build an ARM allmodconfig due to: > arm-allmodconfig > ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! which appears to be triggered by 11d5f15723c9 (netfilter: xt_hashlimit: Create revision 2 to support higher pps rates) introducing a division of a 64 bit number which should be done using do_div(). signature.asc Description: PGP signature