Re: next-20170110 build: 1 failures 4 warnings (next-20170110)

2017-01-11 Thread Sekhar Nori 
On Wednesday 11 January 2017 01:51 AM, Stephen Rothwell wrote:
> Hi Mark,
> 
> On Tue, 10 Jan 2017 18:16:07 + Mark Brown  wrote:
>>
>> On Tue, Jan 10, 2017 at 07:21:32AM +, Build bot for Mark Brown wrote:
>>
>> Today's -next fails to build an arm allmodconfig due to:
>>
>>> arm-allmodconfig
>>> ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from 
>>> incompatible pointer type [-Werror=incompatible-pointer-types]  
>>
>> caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
>> bits).  It's assigning the function
>>
>>   static struct rtnl_link_stats64 *
>>   netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
>>
>> to ndo_get_stats64 which expects a function returning void.
> 
> Yes, but only because commit bc1f44709cf2 ("net: make ndo_get_stats64 a
> void function") entered the net-next tree on the same day ... so it
> needs a followup fixup patch for this new usage.

Keerthy sent a patch fixing this yesterday. Looks like he will have to
spin another version though.

https://patchwork.ozlabs.org/patch/713224/

Thanks,
Sekhar

Re: next-20170110 build: 1 failures 4 warnings (next-20170110)

2017-01-10 Thread Stephen Rothwell 
Hi Mark,

On Tue, 10 Jan 2017 18:16:07 + Mark Brown  wrote:
>
> On Tue, Jan 10, 2017 at 07:21:32AM +, Build bot for Mark Brown wrote:
> 
> Today's -next fails to build an arm allmodconfig due to:
> 
> > arm-allmodconfig
> > ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from 
> > incompatible pointer type [-Werror=incompatible-pointer-types]  
> 
> caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
> bits).  It's assigning the function
> 
>   static struct rtnl_link_stats64 *
>   netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
> 
> to ndo_get_stats64 which expects a function returning void.

Yes, but only because commit bc1f44709cf2 ("net: make ndo_get_stats64 a
void function") entered the net-next tree on the same day ... so it
needs a followup fixup patch for this new usage.

-- 
Cheers,
Stephen Rothwell

Re: next-20170110 build: 1 failures 4 warnings (next-20170110)

2017-01-10 Thread Mark Brown 
On Tue, Jan 10, 2017 at 07:21:32AM +, Build bot for Mark Brown wrote:

Today's -next fails to build an arm allmodconfig due to:

>   arm-allmodconfig
> ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from 
> incompatible pointer type [-Werror=incompatible-pointer-types]

caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
bits).  It's assigning the function

  static struct rtnl_link_stats64 *
  netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)

to ndo_get_stats64 which expects a function returning void.


signature.asc
Description: PGP signature