Re: Request for -stable inclusion: time stamping fix for nfp

[Guillaume Nault]

On Thu, May 17, 2018 at 02:09:03PM -0400, David Miller wrote:
> From: Guillaume Nault 
> Date: Thu, 17 May 2018 19:41:47 +0200
> 
> > On Thu, Nov 16, 2017 at 10:13:28AM +0900, David Miller wrote:
> >> From: Guillaume Nault 
> >> Date: Wed, 15 Nov 2017 17:20:46 +0100
> >> 
> >> > Can you please queue commit 46f1c52e66db
> >> > ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
> >> > We got hit but this bug in the late summer. We run this fix internally
> >> > since a couple of months, but that'd be better to have it officially
> >> > backported so everyone can benefit of it.
> >> 
> >> Queued up.
> > 
> > I guess this one got lost somewhere as it doesn't appear in linux-4.9.y
> > (other trees aren't relevant).
> > If that's unintentional, than can you please re-queue
> > 46f1c52e66db ("nfp: TX time stamp packets before HW doorbell is rung")
> > to -stable?
> 
> I only submit patches to -stable for the two most recent active branches
> which right now consists of 4.16 and 4.14 as per www.kernel.org
> 
Sorry, I didn't know precisely which branches you were actually
handling. I'll remember that for next time.

Re: Request for -stable inclusion: time stamping fix for nfp

[Greg KH]

On Thu, May 17, 2018 at 08:32:02PM +0200, Willy Tarreau wrote:
> Adding Greg here.
> 
> Greg, apparently a backport of 46f1c52e66db is needed in 4.9 according
> to the thread below. It was merged in 4.13 so 4.14 already has it.

Thanks for the notice, now queued up.

greg k-h

Re: Request for -stable inclusion: time stamping fix for nfp

[Willy Tarreau]

Adding Greg here.

Greg, apparently a backport of 46f1c52e66db is needed in 4.9 according
to the thread below. It was merged in 4.13 so 4.14 already has it.

Willy

On Thu, May 17, 2018 at 02:09:03PM -0400, David Miller wrote:
> From: Guillaume Nault 
> Date: Thu, 17 May 2018 19:41:47 +0200
> 
> > On Thu, Nov 16, 2017 at 10:13:28AM +0900, David Miller wrote:
> >> From: Guillaume Nault 
> >> Date: Wed, 15 Nov 2017 17:20:46 +0100
> >> 
> >> > Can you please queue commit 46f1c52e66db
> >> > ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
> >> > We got hit but this bug in the late summer. We run this fix internally
> >> > since a couple of months, but that'd be better to have it officially
> >> > backported so everyone can benefit of it.
> >> 
> >> Queued up.
> > 
> > I guess this one got lost somewhere as it doesn't appear in linux-4.9.y
> > (other trees aren't relevant).
> > If that's unintentional, than can you please re-queue
> > 46f1c52e66db ("nfp: TX time stamp packets before HW doorbell is rung")
> > to -stable?
> 
> I only submit patches to -stable for the two most recent active branches
> which right now consists of 4.16 and 4.14 as per www.kernel.org

Re: Request for -stable inclusion: time stamping fix for nfp

[David Miller]

From: Guillaume Nault 
Date: Thu, 17 May 2018 19:41:47 +0200

> On Thu, Nov 16, 2017 at 10:13:28AM +0900, David Miller wrote:
>> From: Guillaume Nault 
>> Date: Wed, 15 Nov 2017 17:20:46 +0100
>> 
>> > Can you please queue commit 46f1c52e66db
>> > ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
>> > We got hit but this bug in the late summer. We run this fix internally
>> > since a couple of months, but that'd be better to have it officially
>> > backported so everyone can benefit of it.
>> 
>> Queued up.
> 
> I guess this one got lost somewhere as it doesn't appear in linux-4.9.y
> (other trees aren't relevant).
> If that's unintentional, than can you please re-queue
> 46f1c52e66db ("nfp: TX time stamp packets before HW doorbell is rung")
> to -stable?

I only submit patches to -stable for the two most recent active branches
which right now consists of 4.16 and 4.14 as per www.kernel.org

Re: Request for -stable inclusion: time stamping fix for nfp

[Guillaume Nault]

On Thu, Nov 16, 2017 at 10:13:28AM +0900, David Miller wrote:
> From: Guillaume Nault 
> Date: Wed, 15 Nov 2017 17:20:46 +0100
> 
> > Can you please queue commit 46f1c52e66db
> > ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
> > We got hit but this bug in the late summer. We run this fix internally
> > since a couple of months, but that'd be better to have it officially
> > backported so everyone can benefit of it.
> 
> Queued up.

I guess this one got lost somewhere as it doesn't appear in linux-4.9.y
(other trees aren't relevant).
If that's unintentional, than can you please re-queue
46f1c52e66db ("nfp: TX time stamp packets before HW doorbell is rung")
to -stable?

Sorry for noticing so late.

Guillaume

Re: Request for -stable inclusion: time stamping fix for nfp

[David Miller]

From: Guillaume Nault 
Date: Wed, 15 Nov 2017 17:20:46 +0100

> Can you please queue commit 46f1c52e66db
> ("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
> We got hit but this bug in the late summer. We run this fix internally
> since a couple of months, but that'd be better to have it officially
> backported so everyone can benefit of it.

Queued up.

Request for -stable inclusion: time stamping fix for nfp

[Guillaume Nault]

Hi David,

Can you please queue commit 46f1c52e66db
("nfp: TX time stamp packets before HW doorbell is rung") for -stable?
We got hit but this bug in the late summer. We run this fix internally
since a couple of months, but that'd be better to have it officially
backported so everyone can benefit of it.

Regards,

Guillaume

Re: Request for -stable inclusion (xt_TCPMSS)

[David Miller]

From: Guillaume Nault 
Date: Fri, 16 Jun 2017 09:45:17 +0200

> Hi David,
> 
> Please queue 2638fd0f92d4 ("netfilter: xt_TCPMSS: add more sanity tests on 
> tcph->doff")
> for -stable.
> It fixes hard to debug crashes in production, that can be triggered by
> remote peers.

Pablo handles netfilter -stable submissions, so please ask him.

Thank you.

Re: Request for -stable inclusion (xt_TCPMSS)

[Guillaume Nault]

On Fri, Jun 16, 2017 at 11:59:12AM +0200, Pablo Neira Ayuso wrote:
> Hi Guillaume,
> 
> On Fri, Jun 16, 2017 at 09:45:17AM +0200, Guillaume Nault wrote:
> > Hi David,
> > 
> > Please queue 2638fd0f92d4 ("netfilter: xt_TCPMSS: add more sanity tests on 
> > tcph->doff")
> > for -stable.
> > It fixes hard to debug crashes in production, that can be triggered by
> > remote peers.
> 
> What stable kernels you want this in? Does this apply cleanly to them
> all?
> 
I need it (and reviewed/tested it) for 4.9. But the patch applies
cleanly and looks necessary for all stable versions >= 3.16 (not
tested though).

> I can route this for you directly to sta...@vger.kernel.org once we
> sort out these questions.
> 
> Thanks!
Great, thanks Pablo. But do you mean I should have Cc-ed
sta...@vger.kernel.org directly?

Re: Request for -stable inclusion (xt_TCPMSS)

[Pablo Neira Ayuso]

Hi Guillaume,

On Fri, Jun 16, 2017 at 09:45:17AM +0200, Guillaume Nault wrote:
> Hi David,
> 
> Please queue 2638fd0f92d4 ("netfilter: xt_TCPMSS: add more sanity tests on 
> tcph->doff")
> for -stable.
> It fixes hard to debug crashes in production, that can be triggered by
> remote peers.

What stable kernels you want this in? Does this apply cleanly to them
all?

I can route this for you directly to sta...@vger.kernel.org once we
sort out these questions.

Thanks!

Request for -stable inclusion (xt_TCPMSS)

[Guillaume Nault]

Hi David,

Please queue 2638fd0f92d4 ("netfilter: xt_TCPMSS: add more sanity tests on 
tcph->doff")
for -stable.
It fixes hard to debug crashes in production, that can be triggered by
remote peers.

Regards,

Guillaume

request for stable inclusion

[Or Gerlitz]

Hi Dave,

Could you please push to -stable the UAR patch (below), it allows mlx4
to run on PPC systems without hacking PCI BAR sizes. The patch
introduced small regression for people that do prefer to run non
modified VF drivers with modified host driver, and hence should be
accompanied by the  backward compatibility (below too)

76e39cc net/mlx4_core: Fix backward compatibility on VFs
85743f1 net/mlx4_core: Set UAR page size to 4KB regardless of system page size

Thanks,

Or.

Re: request for stable inclusion

[David Miller]

From: Or Gerlitz 
Date: Wed, 16 Sep 2015 09:41:40 +0300

> Hi Dave,
> 
> Commit 9293267 "net/mlx4_core: Capping number of requested MSIXs to
> MAX_MSIX" fixes a bug under which the driver doesn't really starts
> over a machine with > 32 cores.
> 
> The bug was introduced in 4.2-rc1 but the fix missed 4.2 -- could you
> please push it to 4.2 -stable?

Queued up, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

request for stable inclusion

[Or Gerlitz]

Hi Dave,

Commit 9293267 "net/mlx4_core: Capping number of requested MSIXs to 
MAX_MSIX"  fixes a bug under which the driver doesn't really starts over 
a machine with > 32 cores.


The bug was introduced in 4.2-rc1 but the fix missed 4.2 -- could you 
please push it to 4.2 -stable?


If you prefer that we will submit it directly there, fine too.

thanks,

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html