Re: softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1]
On Tue, 25 Jul 2006 01:00:54 +0100 Daniel Drake <[EMAIL PROTECTED]> wrote: > Tom Walter Dillig wrote: > > [109] > > 452 net/ieee80211/softmac/ieee80211softmac_io.c > > Possible null dereference of variable "*pkt" in function call > > (include/asm/string.h:__constant_c_and_count_memset) checked at > > (453:net/ieee80211/softmac/ieee80211softmac_io.c) > > Either I'm misunderstanding, or this is bogus. > > when *pkt is allocated by the various child functions (e.g. > ieee80211softmac_disassoc_deauth), it is always checked for NULL. > > Finally, line 453 does another NULL check. > > What is the report trying to say? That the check in 453 should be removed because is unneeded. People who obsess about code coverage care that there are unneded checks. I don't think it matters. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1]
Tom Walter Dillig wrote: [109] 452 net/ieee80211/softmac/ieee80211softmac_io.c Possible null dereference of variable "*pkt" in function call (include/asm/string.h:__constant_c_and_count_memset) checked at (453:net/ieee80211/softmac/ieee80211softmac_io.c) Either I'm misunderstanding, or this is bogus. when *pkt is allocated by the various child functions (e.g. ieee80211softmac_disassoc_deauth), it is always checked for NULL before being used. Finally, line 453 does another NULL check, so that any failures generated above are handled appropriately. What is the report trying to say? Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1]
Tom Walter Dillig wrote: [109] 452 net/ieee80211/softmac/ieee80211softmac_io.c Possible null dereference of variable "*pkt" in function call (include/asm/string.h:__constant_c_and_count_memset) checked at (453:net/ieee80211/softmac/ieee80211softmac_io.c) Either I'm misunderstanding, or this is bogus. when *pkt is allocated by the various child functions (e.g. ieee80211softmac_disassoc_deauth), it is always checked for NULL. Finally, line 453 does another NULL check. What is the report trying to say? Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
