[PATCH v3] extensions: libxt_NFQUEUE: Add translation to nft

2016-02-07 Thread Shivani Bhardwaj
Add translation for NF queue to nftables.

Examples:

$ sudo iptables-translate -t nat -A PREROUTING -p tcp --dport 80 -j NFQUEUE 
--queue-num 30
nft add rule ip nat PREROUTING tcp dport 80 counter queue num 30

$ sudo iptables-translate -A FORWARD -j NFQUEUE --queue-num 0 --queue-bypass -p 
TCP --sport 80
nft add rule ip filter FORWARD tcp sport 80 counter queue num 0 bypass

$ sudo iptables-translate -A FORWARD -j NFQUEUE --queue-bypass -p TCP --sport 
80 --queue-balance 0:3 --queue-cpu-fanout
nft add rule ip filter FORWARD tcp sport 80 counter queue num 0-3 bypass,fanout

Signed-off-by: Shivani Bhardwaj 
---
Changes in v3:
Add static keyword to sep_need

 extensions/libxt_NFQUEUE.c | 62 +-
 1 file changed, 61 insertions(+), 1 deletion(-)

diff --git a/extensions/libxt_NFQUEUE.c b/extensions/libxt_NFQUEUE.c
index 0c86918..5312630 100644
--- a/extensions/libxt_NFQUEUE.c
+++ b/extensions/libxt_NFQUEUE.c
@@ -205,6 +205,62 @@ static void NFQUEUE_init_v1(struct xt_entry_target *t)
tinfo->queues_total = 1;
 }
 
+static int NFQUEUE_xlate(const struct xt_entry_target *target,
+struct xt_xlate *xl, int numeric)
+{
+   const struct xt_NFQ_info *tinfo =
+   (const struct xt_NFQ_info *)target->data;
+
+   xt_xlate_add(xl, "queue num %u ", tinfo->queuenum);
+
+   return 1;
+}
+
+static int NFQUEUE_xlate_v1(const struct xt_entry_target *target,
+   struct xt_xlate *xl, int numeric)
+{
+   const struct xt_NFQ_info_v1 *tinfo = (const void *)target->data;
+   unsigned int last = tinfo->queues_total;
+
+   if (last > 1) {
+   last += tinfo->queuenum - 1;
+   xt_xlate_add(xl, "queue num %u-%u ", tinfo->queuenum, last);
+   } else {
+   xt_xlate_add(xl, "queue num %u ", tinfo->queuenum);
+   }
+
+   return 1;
+}
+
+static bool sep_need;
+
+static int NFQUEUE_xlate_v2(const struct xt_entry_target *target,
+   struct xt_xlate *xl, int numeric)
+{
+   const struct xt_NFQ_info_v2 *info = (void *) target->data;
+
+   NFQUEUE_xlate_v1(target, xl, numeric);
+
+   if (info->bypass & NFQ_FLAG_BYPASS) {
+   xt_xlate_add(xl, "bypass");
+   sep_need = true;
+   }
+
+   return 1;
+}
+
+static int NFQUEUE_xlate_v3(const struct xt_entry_target *target,
+   struct xt_xlate *xl, int numeric)
+{
+   const struct xt_NFQ_info_v3 *info = (void *)target->data;
+
+   NFQUEUE_xlate_v2(target, xl, numeric);
+   if (info->flags & NFQ_FLAG_CPU_FANOUT)
+   xt_xlate_add(xl, "%sfanout ", sep_need ? "," : "");
+
+   return 1;
+}
+
 static struct xtables_target nfqueue_targets[] = {
 {
.family = NFPROTO_UNSPEC,
@@ -216,7 +272,8 @@ static struct xtables_target nfqueue_targets[] = {
.print  = NFQUEUE_print,
.save   = NFQUEUE_save,
.x6_parse   = NFQUEUE_parse,
-   .x6_options = NFQUEUE_opts
+   .x6_options = NFQUEUE_opts,
+   .xlate  = NFQUEUE_xlate,
 },{
.family = NFPROTO_UNSPEC,
.revision   = 1,
@@ -230,6 +287,7 @@ static struct xtables_target nfqueue_targets[] = {
.save   = NFQUEUE_save_v1,
.x6_parse   = NFQUEUE_parse_v1,
.x6_options = NFQUEUE_opts,
+   .xlate  = NFQUEUE_xlate_v1,
 },{
.family = NFPROTO_UNSPEC,
.revision   = 2,
@@ -243,6 +301,7 @@ static struct xtables_target nfqueue_targets[] = {
.save   = NFQUEUE_save_v2,
.x6_parse   = NFQUEUE_parse_v2,
.x6_options = NFQUEUE_opts,
+   .xlate  = NFQUEUE_xlate_v2,
 },{
.family = NFPROTO_UNSPEC,
.revision   = 3,
@@ -256,6 +315,7 @@ static struct xtables_target nfqueue_targets[] = {
.save   = NFQUEUE_save_v3,
.x6_parse   = NFQUEUE_parse_v3,
.x6_options = NFQUEUE_opts,
+   .xlate  = NFQUEUE_xlate_v3,
 }
 };
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC] a software based on ulogd

2016-02-07 Thread Eric Leblond
Hello Ken-ichirou,

Le 6 févr. 2016 11:42 AM, Ken-ichirou MATSUZAWA  a écrit :
>
> Hi, 
>
> I need Netflow data based on conntrack, I am trying to create a software 
> which is based on ulogd. 
>
>     https://github.com/chamaken/nurs/ 

I feel sorry not being able to merge your work on ulogd due to lack of time on 
my side. Do you think you could resubmit a patchset adding netflow support to 
ulogd ? I will make the necessary to get it included.

Best regards,

> I copied COPYING and README from ulogd source code to distribute, and 
> added comment: 
>
>     based on ulogd which was almost entirely written by Harald Welte, 
>     with contributions from fellow hackers such as Pablo Neira Ayuso, 
>     Eric Leblond and Pierre Chifflier. 
>
> to each source file. Would you tell me other things to reuse ulogd? 
> And I would appreciate it if I could get your advice to this software. 



>
> Thanks, 
> -- 
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in 
> the body of a message to majord...@vger.kernel.org 
> More majordomo info at  http://vger.kernel.org/majordomo-info.html