Re: [PATCH] net: fix description of skb_find_text() according to removed functionality
On Tue, Feb 07, 2017 at 06:45:37PM -0800, Igor Pylypiv wrote:
> Textsearch state parameter was moved to local scope of the function.
> This eliminates usage of textsearch_next() to find subsequent occurrences.
>
> Fixes: 59a2440fd3cf ("net: Remove state argument from skb_find_text()")
> Signed-off-by: Igor Pylypiv
Acked-by: Pablo Neira Ayuso
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: fix description of skb_find_text() according to removed functionality
On Tue, Feb 07, 2017 at 11:13:12PM -0800, Igor Pylypiv wrote: > I am not planning to to add a new user of this functions. > Use of skb_find_text() was a part of my Linux study and its > description informed me that I can use textsearch_next() > which I cannot. Just want to fix this. Send us a patch to update documentation then. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] net: fix description of skb_find_text() according to removed functionality
I am not planning to to add a new user of this functions. Use of skb_find_text() was a part of my Linux study and its description informed me that I can use textsearch_next() which I cannot. Just want to fix this. On Tue, Feb 7, 2017 at 7:02 PM, David Miller wrote: > > How about you make edits to this interface when you add an in-tree > user as we mentioned in our responses to your previous patch? > > Thank you. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: fix description of skb_find_text() according to removed functionality
How about you make edits to this interface when you add an in-tree user as we mentioned in our responses to your previous patch? Thank you. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] net: fix description of skb_find_text() according to removed functionality
Textsearch state parameter was moved to local scope of the function.
This eliminates usage of textsearch_next() to find subsequent occurrences.
Fixes: 59a2440fd3cf ("net: Remove state argument from skb_find_text()")
Signed-off-by: Igor Pylypiv
---
net/core/skbuff.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 9ccba86..90366c5 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2919,9 +2919,8 @@ static void skb_ts_finish(struct ts_config *conf, struct
ts_state *state)
* @config: textsearch configuration
*
* Finds a pattern in the skb data according to the specified
- * textsearch configuration. Use textsearch_next() to retrieve
- * subsequent occurrences of the pattern. Returns the offset
- * to the first occurrence or UINT_MAX if no match was found.
+ * textsearch configuration. Returns the offset to the first
+ * occurrence or UINT_MAX if no match was found.
*/
unsigned int skb_find_text(struct sk_buff *skb, unsigned int from,
unsigned int to, struct ts_config *config)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
