Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison
Hi Arushi, [auto build test WARNING on ipvs-next/master] [also build test WARNING on v4.11-rc5 next-20170407] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/net-netfilter-ipvs-Replace-explicit-NULL-comparison/20170409-044710 base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master config: i386-randconfig-x002-201715 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_net_cleanup': >> net/netfilter/ipvs/ip_vs_proto.c:350:3: warning: suggest parentheses around >> assignment used as truth value [-Wparentheses] while (pd = ipvs->proto_data_table[i]) ^ net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_cleanup': net/netfilter/ipvs/ip_vs_proto.c:395:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses] while (pp = ip_vs_proto_table[i]) ^ vim +350 net/netfilter/ipvs/ip_vs_proto.c 334 goto cleanup; 335 } 336 return 0; 337 338 cleanup: 339 ip_vs_protocol_net_cleanup(ipvs); 340 return ret; 341 } 342 343 void __net_exit ip_vs_protocol_net_cleanup(struct netns_ipvs *ipvs) 344 { 345 struct ip_vs_proto_data *pd; 346 int i; 347 348 /* unregister all the ipvs proto data for this netns */ 349 for (i = 0; i < IP_VS_PROTO_TAB_SIZE; i++) { > 350 while (pd = ipvs->proto_data_table[i]) 351 unregister_ip_vs_proto_netns(ipvs, pd); 352 } 353 } 354 355 int __init ip_vs_protocol_init(void) 356 { 357 char protocols[64]; 358 #define REGISTER_PROTOCOL(p)\ --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison
Arushi, On Sun, Apr 09, 2017 at 06:21:51AM +0800, kbuild test robot wrote: > Hi Arushi, > > [auto build test WARNING on ipvs-next/master] > [also build test WARNING on v4.11-rc5 next-20170407] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Arushi-Singhal/net-netfilter-ipvs-Replace-explicit-NULL-comparison/20170409-044710 > base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git > master > config: i386-randconfig-x002-201715 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All warnings (new ones prefixed by >>): > >net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_net_cleanup': > >> net/netfilter/ipvs/ip_vs_proto.c:350:3: warning: suggest parentheses > >> around assignment used as truth value [-Wparentheses] > while (pd = ipvs->proto_data_table[i]) > ^ This is bad, you have to be more careful in what you do. This is not a speed coding contest. Showing careful patchset handling, even if you submit less of them, is way more prefered in my opinion. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html