Re: [netsniff-ng] [PATCH v2 0/4] flowtop: Add traffic accounting dump

2015-07-17 Thread Tobias Klauser
On 2015-07-13 at 22:03:05 +0200, Vadim Kochan  wrote:
> From: Vadim Kochan 
> 
> Added periodic dump of existing and visible flow to update packets & bytes
> counters.
> 
> Needs to clone nf_conntrack object for new added flow entry to
> update counters for this particular flow, instead of dump entire
> conntrack table. Counters are showed in human readable format in SI units.
> 
> Also added showing count of existing valid flows.
> 
> v2:
> 1) Get rid of separated sysctl.c module, sysctl helpers moved into 
> flowtop.c
> 2) Decreased sleep before poll & update counters to 300ms.
> 3) Increased sleep after refresh presenter to 200ms to give collector more
> time to update each flow.
> 4) Renamed collector_refresh_ct -> collector_refresh_flows
> 
> Vadim Kochan (4):
>   flowtop: Refactor walking for each flow node by presenter
>   flowtop: Add connection traffic accounting
>   flowtop: Show total numbers of flows
>   flowtop: Show flow bytes in human readable format

Series applied, thanks Vadim.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [netsniff-ng] [PATCH v2 0/4] flowtop: Add traffic accounting dump

2015-07-17 Thread Vadim Kochan
On Fri, Jul 17, 2015 at 01:42:56PM +0200, Tobias Klauser wrote:
> On 2015-07-13 at 22:03:05 +0200, Vadim Kochan  wrote:
> > From: Vadim Kochan 
> > 
> > Added periodic dump of existing and visible flow to update packets & bytes
> > counters.
> > 
> > Needs to clone nf_conntrack object for new added flow entry to
> > update counters for this particular flow, instead of dump entire
> > conntrack table. Counters are showed in human readable format in SI units.
> > 
> > Also added showing count of existing valid flows.
> > 
> > v2:
> > 1) Get rid of separated sysctl.c module, sysctl helpers moved into 
> > flowtop.c
> > 2) Decreased sleep before poll & update counters to 300ms.
> > 3) Increased sleep after refresh presenter to 200ms to give collector 
> > more
> > time to update each flow.
> > 4) Renamed collector_refresh_ct -> collector_refresh_flows
> > 
> > Vadim Kochan (4):
> >   flowtop: Refactor walking for each flow node by presenter
> >   flowtop: Add connection traffic accounting
> >   flowtop: Show total numbers of flows
> >   flowtop: Show flow bytes in human readable format
> 
> Series applied, thanks Vadim.

Thank you, I will prepare series to get rid of cond lock from flowtop which 
does not
needed now because screen uninitializing is handled in panic handler now.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [netsniff-ng] [PATCH v2 0/4] flowtop: Add traffic accounting dump

2015-07-17 Thread Tobias Klauser
On 2015-07-17 at 13:46:47 +0200, Vadim Kochan  wrote:
> On Fri, Jul 17, 2015 at 01:42:56PM +0200, Tobias Klauser wrote:
> > On 2015-07-13 at 22:03:05 +0200, Vadim Kochan  wrote:
> > > From: Vadim Kochan 
> > > 
> > > Added periodic dump of existing and visible flow to update packets & bytes
> > > counters.
> > > 
> > > Needs to clone nf_conntrack object for new added flow entry to
> > > update counters for this particular flow, instead of dump entire
> > > conntrack table. Counters are showed in human readable format in SI units.
> > > 
> > > Also added showing count of existing valid flows.
> > > 
> > > v2:
> > > 1) Get rid of separated sysctl.c module, sysctl helpers moved into 
> > > flowtop.c
> > > 2) Decreased sleep before poll & update counters to 300ms.
> > > 3) Increased sleep after refresh presenter to 200ms to give collector 
> > > more
> > > time to update each flow.
> > > 4) Renamed collector_refresh_ct -> collector_refresh_flows
> > > 
> > > Vadim Kochan (4):
> > >   flowtop: Refactor walking for each flow node by presenter
> > >   flowtop: Add connection traffic accounting
> > >   flowtop: Show total numbers of flows
> > >   flowtop: Show flow bytes in human readable format
> > 
> > Series applied, thanks Vadim.
> 
> Thank you, I will prepare series to get rid of cond lock from flowtop which 
> does not
> needed now because screen uninitializing is handled in panic handler now.

Perfect! Looking forward to this. Thanks a lot for your work.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.