[netsniff-ng] Re: [PATCH v3 0/6] flowtop: Layout change to 1-row view (part #2)

[Tobias Klauser]

On 2016-04-21 at 20:47:37 +0200, Vadim Kochan  wrote:
> This is a 2nd part of series about changing flowtop layout to 1-row
> view. This version is mostly a refactoring of flows refreshing to
> make it more generic by using UI table API.
> 
> v3:
> 1) Fixed headers including
> 
> 2) Fixed trailing tab in ui.c
> 
> 3) Replaced panic(...) by bug_on(true) in ui table column lookup function.

Note that you can also use bug() as a shorthand for bug_on(true). I
changed your patches accordingly before applying.

> 4) Clear screen on init.
> v2:
> 1) Add UI table widget with generic implementation for
>print list items in table style. Add new UI module with
>generic table API.
> 
> 2) Add Linux-like list API used from liburcu but with redefinitions
>to the Linux naming.
> 
> 3) Get rid of clear & refresh screen each time while flows printing.
> 
> Vadim Kochan (6):
>   list: Add re-defined double-linked list API from liburcu
>   ui: Implement UI table for flows printing
>   flowtop: Use new UI table API for draw flows list
>   ui: Print empty rows when clear table
>   flowtop: Get rid of clear() & refresh() calls
>   flowtop: Simplify flows refresh delay

Series applied, thanks Vadim!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH] flowtop: Fix compilation error when build without geoip

[Tobias Klauser]

On 2016-04-22 at 06:05:47 +0200, Vadim Kochan  wrote:
> Commit (f61f39d geoip: Allow to get country 3-code) added
> new helpers without considering HAVE_GEOIP definition.
> 
> Fixed by adding dummy functions for get 3-code country name
> in case if HAVE_GEOIP is not defined.
> 
> Tested only by manualy disabling HAVE_GEOIP in config.h
> and geoip.c compilation in Config file.
> 
> Fixes: f61f39d (geoip: Allow to get country 3-code)
> Reported-by: Daniel Borkmann 
> Signed-off-by: Vadim Kochan 

Applied. Thanks Daniel and Vadim!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.