Re: [netsniff-ng] [PATCH 0/2] mmaped netlink packet

2015-09-15 Thread Tobias Klauser
On 2015-09-11 at 09:56:05 +0200, Ken-ichirou MATSUZAWA  
wrote:
>  Hi,
> 
> Thanks to Daniel, I can see mmaped netlink packet by netsniff-ng,
> but something is a little wrong. It seems that netsniff-ng can not
> get actual packet size. The output is like:
> 
>   >K ? 16360 1441873543s.15990ns #1
>[ NLMSG Family 12 (Netfilter), Len 916, Type 0x0300 (0x300), Flags 0x 
> (), Seq-Nr 0, PID 0 (
>   kernel) ]
>[ NLMSG Family 12 (Netfilter), Len 0, Type 0x (0x0), Flags 0x (), 
> Seq-Nr 0, PID 0 (ker
>   nel) ]
>[ Chr 
> 
>  
> 
> ...
>[ Hex  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0
>  0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0
> ... 
> 
> I think it's because mmaped skb size is equals to its frame size,
> may differ from actual size, and we can fix it by checking the next
> nlmsg len.
> 
> Would you review the following patches?

Looks good to me, series now applied. Thank you!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] [PATCH 0/2] mmaped netlink packet

2015-09-11 Thread Ken-ichirou MATSUZAWA
 Hi,

Thanks to Daniel, I can see mmaped netlink packet by netsniff-ng,
but something is a little wrong. It seems that netsniff-ng can not
get actual packet size. The output is like:

  >K ? 16360 1441873543s.15990ns #1
   [ NLMSG Family 12 (Netfilter), Len 916, Type 0x0300 (0x300), Flags 0x 
(), Seq-Nr 0, PID 0 (
  kernel) ]
   [ NLMSG Family 12 (Netfilter), Len 0, Type 0x (0x0), Flags 0x (), 
Seq-Nr 0, PID 0 (ker
  nel) ]
   [ Chr 

 

...
   [ Hex  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0
 0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0
... 

I think it's because mmaped skb size is equals to its frame size,
may differ from actual size, and we can fix it by checking the next
nlmsg len.

Would you review the following patches?
Thanks,

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.