Re: NetworkManager with hidden ESSID

2006-11-02 Thread Riko Wichmann
Hi again,

I wanted to check both at home and at work before answering the questions.

 I have a problem with NetworkManager at work, where the APs don't 
 broadcast their ESSID. At home, where I don't hide the ESSID, there is 
 no problem.

Actually, I was wrong, also my AP at home hides its ESSID 

 
 Does the AP show up in the scan list if you do a manual iwlist ethX
 scan as root?

It does show up at home (with hidden ESSID as mentioned above).
It does *NOT* show up at work. Only after I configured the network 
entering the ESSID and the WEP key manually, the AP shows up in the 
iwlist scan.

So there is a clear difference between the two locations

 
 So, here it goes: I'm running NetworkManager on a Dell D600 and really 
 like it, especially the dispatcher feature. However, when I'm at work, 
 the internal wireless network does not show up in the list that the 
 nm-applet provides. I can connect to it without problem using the 
 'Connect to other wireless networks' option. Then it shows in the list. 
 However, next time I reboot the machine and look into the applet, the 
 internal network is gone again from the list. It's a WEP encrypted 
 network, if that makes any difference.

 in ~/.gconf/system/networking/wireless/networks I find a configuration 
 for the network, but it never shows up. It kind of defeats the purpose 
 of NetworkManager, if you need to configure the same network all the 
 time again.
 
 Does the AP's bssid (looks like a MAC address) show up in the bssids
 key in the saved settings for that wireless network?  NM caches the
 BSSID of base stations it's connected to for each wireless network, and
 then reverse-matches those to the BSSIDs it finds in the scan list, and
 that's how it finds hidden SSID access points.  We need to figure out
 which part here is breaking down.

Yes, the bssid is stored in the settings. In fact, since I saw from the 
iwlist scan results, that there are apparently 2 APs for the same 
network, I added the second bssid to the settings manually using 
gconf-editor. But again, after a reboot of the machine, the internal 
network was not available in the network list.

Thanks,

  Riko
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: NetworkManager with hidden ESSID

2006-11-02 Thread Riko Wichmann
hi,

Aloisio wrote:
 Hi,
 
 Do you know if there has more than one AP with same SSID in the same
 place?? In large places this is necessary to provide enought signal
 quality. If in the last time you have connected to AP with mac address
 X, nm make an association between X and the SSID, right ? But when it
 gets scan results, you can have X, Y and W APs providing connection
 and both with same SSID, and both hidden. The question is: in this
 case, what nm do ? I will able to connect only on X AP (if the SSID
 appear in list)? Can nm associate more than one mac address to a SSID
 ? The SSID does not appear because Y or W have more sinal quality than
 X ?

Yes, there are at least 2 APs near my office for the same network (see 
my post a few minutes ago). I added the bssid of the second AP to the 
network settings with gconf-editor. However, the network was still not 
recognized after a reboot of the machine.

Cheers,

Riko


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


[Patch] Fix a bunch of leaks

2006-11-02 Thread Tambet Ingo
Hey,

Just as the subject says, fix about 10 memory leaks.

Tambet
Index: gnome/applet/applet.c
===
RCS file: /cvs/gnome/NetworkManager/gnome/applet/applet.c,v
retrieving revision 1.112.2.12
diff -u -r1.112.2.12 applet.c
--- gnome/applet/applet.c	25 Oct 2006 03:39:20 -	1.112.2.12
+++ gnome/applet/applet.c	2 Nov 2006 15:23:09 -
@@ -1764,12 +1764,14 @@
 
 		label = g_strdup_printf (_(Connect to %s...), name);
 		connect_item = GTK_MENU_ITEM (gtk_menu_item_new_with_label (label));
+		g_free (label);
 		g_object_set_data (G_OBJECT (connect_item), dialup, name);
 		g_signal_connect (G_OBJECT (connect_item), activate, G_CALLBACK (nma_menu_dialup_connect_item_activate), applet);
 		gtk_menu_shell_append (GTK_MENU_SHELL (dialup_menu), GTK_WIDGET (connect_item));
 
 		label = g_strdup_printf (_(Disconnect from %s...), name);
 		disconnect_item = GTK_MENU_ITEM (gtk_menu_item_new_with_label (label));
+		g_free (label);
 		g_object_set_data (G_OBJECT (disconnect_item), dialup, name);
 		g_signal_connect (G_OBJECT (disconnect_item), activate, G_CALLBACK (nma_menu_dialup_disconnect_item_activate), applet);
 		gtk_menu_shell_append (GTK_MENU_SHELL (dialup_menu), GTK_WIDGET (disconnect_item));
Index: gnome/applet/menu-items.c
===
RCS file: /cvs/gnome/NetworkManager/gnome/applet/menu-items.c,v
retrieving revision 1.12.2.1
diff -u -r1.12.2.1 menu-items.c
--- gnome/applet/menu-items.c	17 May 2006 20:03:56 -	1.12.2.1
+++ gnome/applet/menu-items.c	2 Nov 2006 15:23:09 -
@@ -91,6 +91,7 @@
 		text = g_strdup (_(_Wired Network));
 
 	gtk_label_set_text_with_mnemonic (GTK_LABEL (item-label), text);
+	g_free (text);
 
 	/* Only dim the item if the device supports carrier detection AND
 	 * we know it doesn't have a link.
Index: src/nm-dbus-device.c
===
RCS file: /cvs/gnome/NetworkManager/src/nm-dbus-device.c,v
retrieving revision 1.27.2.1
diff -u -r1.27.2.1 nm-dbus-device.c
--- src/nm-dbus-device.c	21 Jun 2006 14:33:35 -	1.27.2.1
+++ src/nm-dbus-device.c	2 Nov 2006 15:23:09 -
@@ -489,6 +489,8 @@
 		g_free (ip4_address);
 		g_free (broadcast);
 		g_free (subnetmask);
+		g_free (primary_dns);
+		g_free (secondary_dns);
 	}
 
 	return reply;
Index: src/nm-device.c
===
RCS file: /cvs/gnome/NetworkManager/src/nm-device.c,v
retrieving revision 1.17.2.7
diff -u -r1.17.2.7 nm-device.c
--- src/nm-device.c	20 Sep 2006 15:35:12 -	1.17.2.7
+++ src/nm-device.c	2 Nov 2006 15:23:10 -
@@ -85,14 +85,22 @@
 discover_device_type (LibHalContext *ctx, const char *udi)
 {
 	char * category = NULL;
+	NMDeviceType type = DEVICE_TYPE_UNKNOWN;
 
 	if (libhal_device_property_exists (ctx, udi, info.category, NULL))
 		category = libhal_device_get_property_string(ctx, udi, info.category, NULL);
-	if (category  (!strcmp (category, net.80211)))
-		return DEVICE_TYPE_802_11_WIRELESS;
-	else if (category  (!strcmp (category, net.80203)))
-		return DEVICE_TYPE_802_3_ETHERNET;
-	return DEVICE_TYPE_UNKNOWN;
+
+	if (category)
+	{
+		if (!strcmp (category, net.80211))
+			type = DEVICE_TYPE_802_11_WIRELESS;
+		else if (!strcmp (category, net.80203))
+			type = DEVICE_TYPE_802_3_ETHERNET;
+
+		libhal_free_string (category);
+	}
+
+	return type;
 }
 
 /*
Index: src/backends/NetworkManagerSuSE.c
===
RCS file: /cvs/gnome/NetworkManager/src/backends/NetworkManagerSuSE.c,v
retrieving revision 1.32.2.23
diff -u -r1.32.2.23 NetworkManagerSuSE.c
--- src/backends/NetworkManagerSuSE.c	19 Oct 2006 20:39:54 -	1.32.2.23
+++ src/backends/NetworkManagerSuSE.c	2 Nov 2006 15:23:10 -
@@ -808,6 +808,8 @@
 
 	if (sys_data-config)
 		nm_ip4_config_unref (sys_data-config);
+
+	g_free (sys_data);
 }
 
 
Index: src/backends/shvar.c
===
RCS file: /cvs/gnome/NetworkManager/src/backends/shvar.c,v
retrieving revision 1.2
diff -u -r1.2 shvar.c
--- src/backends/shvar.c	6 May 2005 21:20:42 -	1.2
+++ src/backends/shvar.c	2 Nov 2006 15:23:10 -
@@ -392,7 +392,12 @@
 }
 g_free(s-fileName);
 g_list_free(s-freeList);
-g_list_free(s-lineList); /* implicitly frees s-current */
+
+	if (s-lineList) {
+		g_list_foreach(s-lineList, (GFunc) g_free, NULL);
+		g_list_free(s-lineList); /* implicitly frees s-current */
+	}
+
 g_free(s);
 return 0;
 }
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: [Patch] Fix a bunch of leaks

2006-11-02 Thread Tambet Ingo
Here's a diff that includes fixes to another couple of leaks.

Tambet

On Thu, 2006-11-02 at 17:23 +0200, Tambet Ingo wrote:
 Hey,
 
 Just as the subject says, fix about 10 memory leaks.
 
 Tambet
 ___
 NetworkManager-list mailing list
 NetworkManager-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/networkmanager-list
Index: gnome/applet/applet.c
===
RCS file: /cvs/gnome/NetworkManager/gnome/applet/applet.c,v
retrieving revision 1.112.2.12
diff -u -r1.112.2.12 applet.c
--- gnome/applet/applet.c	25 Oct 2006 03:39:20 -	1.112.2.12
+++ gnome/applet/applet.c	2 Nov 2006 16:01:10 -
@@ -1764,12 +1764,14 @@
 
 		label = g_strdup_printf (_(Connect to %s...), name);
 		connect_item = GTK_MENU_ITEM (gtk_menu_item_new_with_label (label));
+		g_free (label);
 		g_object_set_data (G_OBJECT (connect_item), dialup, name);
 		g_signal_connect (G_OBJECT (connect_item), activate, G_CALLBACK (nma_menu_dialup_connect_item_activate), applet);
 		gtk_menu_shell_append (GTK_MENU_SHELL (dialup_menu), GTK_WIDGET (connect_item));
 
 		label = g_strdup_printf (_(Disconnect from %s...), name);
 		disconnect_item = GTK_MENU_ITEM (gtk_menu_item_new_with_label (label));
+		g_free (label);
 		g_object_set_data (G_OBJECT (disconnect_item), dialup, name);
 		g_signal_connect (G_OBJECT (disconnect_item), activate, G_CALLBACK (nma_menu_dialup_disconnect_item_activate), applet);
 		gtk_menu_shell_append (GTK_MENU_SHELL (dialup_menu), GTK_WIDGET (disconnect_item));
Index: gnome/applet/menu-items.c
===
RCS file: /cvs/gnome/NetworkManager/gnome/applet/menu-items.c,v
retrieving revision 1.12.2.1
diff -u -r1.12.2.1 menu-items.c
--- gnome/applet/menu-items.c	17 May 2006 20:03:56 -	1.12.2.1
+++ gnome/applet/menu-items.c	2 Nov 2006 16:01:10 -
@@ -91,6 +91,7 @@
 		text = g_strdup (_(_Wired Network));
 
 	gtk_label_set_text_with_mnemonic (GTK_LABEL (item-label), text);
+	g_free (text);
 
 	/* Only dim the item if the device supports carrier detection AND
 	 * we know it doesn't have a link.
Index: src/NetworkManager.c
===
RCS file: /cvs/gnome/NetworkManager/src/NetworkManager.c,v
retrieving revision 1.104.2.5
diff -u -r1.104.2.5 NetworkManager.c
--- src/NetworkManager.c	20 Sep 2006 15:35:12 -	1.104.2.5
+++ src/NetworkManager.c	2 Nov 2006 16:01:10 -
@@ -531,6 +531,11 @@
 	g_main_loop_unref (data-main_loop);
 	g_main_context_unref (data-main_context);
 
+	nm_dbus_method_list_free (data-nm_methods);
+	nm_dbus_method_list_free (data-device_methods);
+	nm_dbus_method_list_free (data-net_methods);
+	nm_dbus_method_list_free (data-vpn_ethods);
+
 	g_io_channel_unref(data-sigterm_iochannel);
 
 	nm_hal_deinit (data);
Index: src/nm-dbus-device.c
===
RCS file: /cvs/gnome/NetworkManager/src/nm-dbus-device.c,v
retrieving revision 1.27.2.1
diff -u -r1.27.2.1 nm-dbus-device.c
--- src/nm-dbus-device.c	21 Jun 2006 14:33:35 -	1.27.2.1
+++ src/nm-dbus-device.c	2 Nov 2006 16:01:10 -
@@ -489,6 +489,8 @@
 		g_free (ip4_address);
 		g_free (broadcast);
 		g_free (subnetmask);
+		g_free (primary_dns);
+		g_free (secondary_dns);
 	}
 
 	return reply;
Index: src/nm-device.c
===
RCS file: /cvs/gnome/NetworkManager/src/nm-device.c,v
retrieving revision 1.17.2.7
diff -u -r1.17.2.7 nm-device.c
--- src/nm-device.c	20 Sep 2006 15:35:12 -	1.17.2.7
+++ src/nm-device.c	2 Nov 2006 16:01:11 -
@@ -85,14 +85,22 @@
 discover_device_type (LibHalContext *ctx, const char *udi)
 {
 	char * category = NULL;
+	NMDeviceType type = DEVICE_TYPE_UNKNOWN;
 
 	if (libhal_device_property_exists (ctx, udi, info.category, NULL))
 		category = libhal_device_get_property_string(ctx, udi, info.category, NULL);
-	if (category  (!strcmp (category, net.80211)))
-		return DEVICE_TYPE_802_11_WIRELESS;
-	else if (category  (!strcmp (category, net.80203)))
-		return DEVICE_TYPE_802_3_ETHERNET;
-	return DEVICE_TYPE_UNKNOWN;
+
+	if (category)
+	{
+		if (!strcmp (category, net.80211))
+			type = DEVICE_TYPE_802_11_WIRELESS;
+		else if (!strcmp (category, net.80203))
+			type = DEVICE_TYPE_802_3_ETHERNET;
+
+		libhal_free_string (category);
+	}
+
+	return type;
 }
 
 /*
Index: src/backends/NetworkManagerSuSE.c
===
RCS file: /cvs/gnome/NetworkManager/src/backends/NetworkManagerSuSE.c,v
retrieving revision 1.32.2.23
diff -u -r1.32.2.23 NetworkManagerSuSE.c
--- src/backends/NetworkManagerSuSE.c	19 Oct 2006 20:39:54 -	1.32.2.23
+++ src/backends/NetworkManagerSuSE.c	2 Nov 2006 16:01:11 -
@@ -808,6 +808,8 @@
 
 	if (sys_data-config)
 		nm_ip4_config_unref (sys_data-config);
+
+	g_free (sys_data);
 }
 
 
Index: src/backends/shvar.c

Re: suspend, hibernation

2006-11-02 Thread Krzysztof Kaczmarski
Nikolaus Filus wrote:
 Hi,

 Krzysztof Kaczmarski wrote:
   
 None of automatic solutions works for me :(
 

 which of the solutions described there did you try?
   
Wow. It somehow works now.
For me the correct solution is:

/etc/acpi/suspend.d/07-network-manager.sh
#!/bin/sh
/etc/dbus-1/event.d/25NetworkManager stop

and

/etc/acpi/resume.d/99-network-manager.sh
#!/bin/sh
/etc/dbus-1/event.d/25NetworkManager start

It looks like 07 and 99 are significant here.

Now I may smoothly wake up my laptop after hibernate or suspend.
Thanks to all of you !

KK



___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list