[Patch] Validate input in vpnc importer
Here's a patch to check if the pcf file values contain non-utf8
characters and tries quite hard to produce valid utf8 from it. First,
using the current locale and ISO-8859-15 (usable for majority of western
european languages) if that fails.
Tambet
? nm-vpnc-pcf-import-utf8.diff
? po/cs.gmo
? po/de.gmo
? po/es.gmo
? po/fi.gmo
? po/fr.gmo
? po/hu.gmo
? po/it.gmo
? po/ja.gmo
? po/pl.gmo
? po/pt_BR.gmo
? po/zh_CN.gmo
? po/zh_TW.gmo
Index: properties/pcf-file.c
===
RCS file: /cvs/gnome/NetworkManager/vpn-daemons/vpnc/properties/pcf-file.c,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 pcf-file.c
--- properties/pcf-file.c 1 Nov 2006 16:33:28 - 1.1.2.1
+++ properties/pcf-file.c 13 Nov 2006 11:12:09 -
@@ -15,6 +15,32 @@
}
}
+/* Stolen from gaim */
+
+static char *
+pcf_utf8_try_convert (const char *str)
+{
+ char *utf8;
+ gsize converted;
+
+ if (!str)
+ return NULL;
+
+ if (g_utf8_validate (str, -1, NULL))
+ return g_strdup (str);
+
+ utf8 = g_locale_to_utf8 (str, -1, NULL, NULL, NULL);
+ if (utf8)
+ return utf8;
+
+ utf8 = g_convert (str, -1, UTF-8, ISO-8859-15, converted, NULL, NULL);
+ if (utf8 converted == strlen (str))
+ return utf8;
+
+ g_free (utf8);
+ return NULL;
+}
+
/*
The main reader loop here is based on the simple .ini file
parser from avahi/avahi-daemon/ini-file-parser.c
@@ -87,7 +113,7 @@
*(e++) = 0;
entry = g_new (PcfEntry, 1);
- entry-value = g_strdup (e);
+ entry-value = pcf_utf8_try_convert (e);
if (*s == '!') {
entry-key = g_utf8_strdown (s+1, -1);
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
On Sun, 2006-11-12 at 23:25 -0500, Dan Williams wrote: On Thu, 2006-11-09 at 20:01 -0400, Derek Broughton wrote: How do I prevent Network manager from doing this really annoying pseudo-connection with IP 169.254.56.71 NetworkManager: information^INo DHCP reply received. Automatically obtaining IP via Zeroconf. NetworkManager: information^Iautoip: Sending probe #0 for IP address 169.254.56.71. I suppose if you have no Internet connection but you do have a LAN, it might have some value - but really, most LANs have a DHCP server. When I can't reach my DHCP server I don't WANT the system to think I'm network connected. Why can't it reach your DHCP server, but yet you are connected just fine to your access point? It seems the problem is that the DHCP server is not responding, not what NM does when it can't find your DHCP server. In any case, in 0.7 with the better configuration structure, it's not out of the question to add a Don't do autoip for this connection switch buried somewhere in prefs for those people that don't want it. Dan Dan All sorts of things start to happen when I connect - ntp, nntp, pop imap clients all start to ask for data, and it's a whole lot easier just to tell my system the truth - that there's no network connection - than to try to change all their scripts. ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [Patch] Validate input in vpnc importer
On Mon, 2006-11-13 at 13:16 +0200, Tambet Ingo wrote: Here's a patch to check if the pcf file values contain non-utf8 characters and tries quite hard to produce valid utf8 from it. First, using the current locale and ISO-8859-15 (usable for majority of western european languages) if that fails. Sure. For both head and stable, rigth? Dan Tambet ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: How to configure wired network device
On Mon, 2006-11-13 at 13:50 +0100, Stefan Vater wrote: Hi, I am using NetworkManager 0.6.2 on SuSE 10.1. For my wired connection I am using the tg3 driver. Since I do not get full duplex using auto negotiation when I connect to the network of my institute, I would like to set this manually. With ethtool I can set this on the command line with ethtool -s eth0 speed 100 duplex full autoneg off But how can I set this each time when NetworkManager connects? Just setting in /etc/sysconfig/network/ifcfg-eth* ETHTOOL_OPTIONS='autoneg off speed 100 duplex full' did not work. It seems to me that NetworkManager does not use this file for configuration. NetworkManager doesn't support these options at this time... Dan Any help is appreciated! Regards, Stefan __ Ein Herz für Kinder - Ihre Spende hilft! Aktion: www.deutschlandsegelt.de Unser Dankeschön: Ihr Name auf dem Segel der 1. deutschen America's Cup-Yacht! ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
On Mon, 2006-11-13 at 07:17 -0500, Dan Williams wrote: On Sun, 2006-11-12 at 23:25 -0500, Dan Williams wrote: On Thu, 2006-11-09 at 20:01 -0400, Derek Broughton wrote: How do I prevent Network manager from doing this really annoying pseudo-connection with IP 169.254.56.71 NetworkManager: information^INo DHCP reply received. Automatically obtaining IP via Zeroconf. NetworkManager: information^Iautoip: Sending probe #0 for IP address 169.254.56.71. I suppose if you have no Internet connection but you do have a LAN, it might have some value - but really, most LANs have a DHCP server. When I can't reach my DHCP server I don't WANT the system to think I'm network connected. Why can't it reach your DHCP server, but yet you are connected just fine to your access point? It seems the problem is that the DHCP server is not responding, not what NM does when it can't find your DHCP server. In any case, in 0.7 with the better configuration structure, it's not out of the question to add a Don't do autoip for this connection switch buried somewhere in prefs for those people that don't want it. I agree with Derek on this point. If applications are relying on the connectivity status from network manager, then it causes the apps to do the wrong thing if nm says it's connected. Most apps will assume this means connected to the internet, no? Perhaps it would be a good idea to have two different connected signals, one for internet availability, and one for autoip. I believe there was some discussion about having different icons in the past as well; is that still in the works? My 2 cents worth. Jason Martens ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Is there a way / plugin to make Network manager use installed cisco vpnclient?
Christopher Aillon [EMAIL PROTECTED] writes: See the following post from Tomas Mraz of Red Hat: http://lists.unix-ag.uni-kl.de/pipermail/vpnc-devel/2006-March/000864.html Fedora carries several patches for this, and I've gone days without losing connection. Good to know.. The last time I tried keeping it up for long periods of time was back with 0.3.2 in FC3. I'm glad to hear that it's working better now. -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH [EMAIL PROTECTED]PGP key available ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
On Monday 13 November 2006 00:25, Dan Williams wrote: On Thu, 2006-11-09 at 20:01 -0400, Derek Broughton wrote: How do I prevent Network manager from doing this really annoying pseudo-connection with IP 169.254.56.71 NetworkManager: information^INo DHCP reply received. Automatically obtaining IP via Zeroconf. NetworkManager: information^Iautoip: Sending probe #0 for IP address 169.254.56.71. I suppose if you have no Internet connection but you do have a LAN, it might have some value - but really, most LANs have a DHCP server. When I can't reach my DHCP server I don't WANT the system to think I'm network connected. Why can't it reach your DHCP server, but yet you are connected just fine to your access point? It seems the problem is that the DHCP server is not responding, not what NM does when it can't find your DHCP server. It can't reach my DHCP server because I am wired to a WRT50G in client mode, wirelessly connected at great distance to my DHCP server and Internet connection. When the weather's really bad, the wireless connection doesn't work. Of course you're right that the problem is that my DHCP server isn't responding - but I want my system to act as if that's the same as no network connection, rather than configuring autoip. It's not as if I can do anything at all with that IP address. -- derek ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
I also agree with Derek on this point. AutoIP is kind of dumb, if the DHCP server fails then AutoIP does not help the user. The Auto IP assigned is not going to be in the same range of the IP range that is to be used. So the connection is usless and Network Manger is telling them everything is fine. If there is an option AutoIP should be off by default. I would like to hear a case where it is actually useful on by default for your average user. It has been a bit annoying as it does give you a false since that things are ok..then you can't connect to anywhere..you check the IP and realize that AutoIP kicked in. On 11/13/06, Derek Broughton [EMAIL PROTECTED] wrote: On Monday 13 November 2006 00:25, Dan Williams wrote: On Thu, 2006-11-09 at 20:01 -0400, Derek Broughton wrote: How do I prevent Network manager from doing this really annoying pseudo-connection with IP 169.254.56.71 NetworkManager: information^INo DHCP reply received. Automatically obtaining IP via Zeroconf. NetworkManager: information^Iautoip: Sending probe #0 for IP address 169.254.56.71. I suppose if you have no Internet connection but you do have a LAN, it might have some value - but really, most LANs have a DHCP server. When I can't reach my DHCP server I don't WANT the system to think I'm network connected. Why can't it reach your DHCP server, but yet you are connected just fine to your access point? It seems the problem is that the DHCP server is not responding, not what NM does when it can't find your DHCP server. It can't reach my DHCP server because I am wired to a WRT50G in client mode, wirelessly connected at great distance to my DHCP server and Internet connection. When the weather's really bad, the wireless connection doesn't work. Of course you're right that the problem is that my DHCP server isn't responding - but I want my system to act as if that's the same as no network connection, rather than configuring autoip. It's not as if I can do anything at all with that IP address. -- derek ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
I would like to hear a case where it is actually useful on by default for your average user. I find it very useful when connecting my laptop via a crossover cable to another computer. Saves me the effort of bring the network connection up myself (or having to remember to enable the option first). That's kinda the point of NetworkManager ... zero (or little) configuration needed for most use cases. As to the notion of firing off different signals depending on connection status, that opens a whole can of worms. You cannot boil it down to just two, if that's the route taken. Just because you can connect to a DHCP server does not imply an Internet connection. Chase Urich ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Autoip
On 11/13/06, Chase Urich [EMAIL PROTECTED] wrote: I would like to hear a case where it is actually useful on by default for your average user. I find it very useful when connecting my laptop via a crossover cable to another computer. Saves me the effort of bring the network connection up myself (or having to remember to enable the option first). That's kinda the point of NetworkManager ... zero (or little) configuration needed for most use cases. As to the notion of firing off different signals depending on connection status, that opens a whole can of worms. You cannot boil it down to just two, if that's the route taken. Just because you can connect to a DHCP server does not imply an Internet connection But it does imply that you have a working connection to the network (you might not want to connect to the internet, just network resources). I think the cross wire route is very rare amongst people today (I used to do it a lot, not really anymore). I think that the best solution for this is to have a window pop up to configure your connection. This does kind of defeat the zeroconf, but it is a trade off. One or the other. I think at least if it's going to use AutoIP then the user should have some visual indication of this. Maybe a network icon with a caution sign. But this really should be an option. By default auto ip is off. If someone wants to do cross over cable route they can turn it on. Chase Urich ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
