parent (GUdevDevice) uninitialized in _update_s390_subchannels
Hi,
I noticed NM fails to build on Ubuntu Natty:
gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../include -I../marshallers
-I../src/logging -I../src/dns-manager -I../src/vpn-manager
-I../src/dhcp-manager -I../src/ip6-manager -I../src/supplicant-manager
-I../src/dnsmasq-manager -I../src/modem-manager -I../src/bluez-manager
-I../src/system-settings -I../libnm-util -I../libnm-glib -I../callouts
-pthread -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread
-I/usr/include/gudev-1.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include-pthread -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -pthread -I/usr/include/polkit-1
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-DG_DISABLE_DEPRECATED -DBINDIR=\"/usr/bin\" -DSBINDIR=\"/usr/sbin\"
-DLIBEXECDIR=\"/usr/lib/NetworkManager\" -DDATADIR=\"/usr/share\"
-DSYSCONFDIR=\"/etc\" -DLOCALSTATEDIR=\"/var\" -DNM_RUN_DIR=
\"/var/run/NetworkManager\" -DNMLOCALEDIR=\"/usr/share/locale\"
-DARP_DEBUG -Wall -Werror -std=gnu89 -g -O2 -g -Wall -O2 -Wshadow
-Wmissing-declarations -Wmissing-prototypes
-Wdeclaration-after-statement -Wfloat-equal -Wno-unused-parameter
-Wno-sign-compare -fno-strict-aliasing -c -o
NetworkManager-nm-device-ethernet.o `test -f 'nm-device-ethernet.c' ||
echo './'`nm-device-ethernet.c
cc1: warnings being treated as errors
nm-device-ethernet.c: In function ‘constructor’:
nm-device-ethernet.c:400:5: error: ‘parent’ may be used uninitialized in
this function
nm-device-ethernet.c:311:15: note: ‘parent’ was declared here
make[5]: *** [NetworkManager-nm-device-ethernet.o] Erreur 1
make[5]: quittant le répertoire
« /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
make[4]: *** [all-recursive] Erreur 1
make[4]: quittant le répertoire
« /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
make[3]: *** [all] Erreur 2
make[3]: quittant le répertoire
« /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2/src »
make[2]: *** [all-recursive] Erreur 1
make[2]: quittant le répertoire
« /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2 »
make[1]: *** [all] Erreur 2
make[1]: quittant le répertoire
« /home/mtrudel/Projects/ubuntu/build-area/network-manager-0.8.2 »
make: *** [debian/stamp-makefile-build] Erreur 2
Attached is the patch I applied.
--
Mathieu Trudel-Lapierre
Freenode: cyphermox, Jabber: mathieu...@gmail.com
4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93
From: Mathieu Trudel-Lapierre
Subject: Fix the build on natty chroots to complete successfully.
This seems to be required because of new strictness in gcc.
Index: network-manager-0.8.1+git.20100810t184654.ab580f4/src/nm-device-ethernet.c
===
--- network-manager-0.8.1+git.20100810t184654.ab580f4.orig/src/nm-device-ethernet.c 2010-10-20 08:55:38.078431122 -0400
+++ network-manager-0.8.1+git.20100810t184654.ab580f4/src/nm-device-ethernet.c 2010-10-20 08:55:47.408431122 -0400
@@ -307,7 +307,7 @@
const char *iface;
GUdevClient *client;
GUdevDevice *dev;
- GUdevDevice *parent;
+ GUdevDevice *parent = NULL;
const char *parent_path, *item, *driver;
const char *subsystems[] = { "net", NULL };
GDir *dir;
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: is there anyone here who understands the vpn implementation
On Thu, Nov 4, 2010 at 4:52 AM, Daniel Wagner wrote:
> Hi Thomas,
>
> On Wed, Nov 03, 2010 at 10:01:27AM -0700, Thomas Bushnell, BSG wrote:
> > I've asked a few questions and gotten deafening silence. I'm not a bozo,
> and
> > I was hoping for slightly more.
> >
> > Is there anyone here who understands the VPN plugin implementation in
> > network manager?
>
> I have looked into the way NM handles this. If I got it right it works
> like this: For each type of VPN implementation (e.g. openvpn) there
> exists a helper daemon which exports an D-Bus interface. The helper
> VPN daemon is spawnding the real VPN deamon. In the case of OpenVPN it
> will start the daemon with few general arguments (e.g. client mode
> etc) and a script argument ('--up') which will be called when OpenVPN
> changes state (e.g. gets connected). The script called by OpenVPN is a
> callback function into the VPN helper daemon which results into an
> D-Bus message to NM.
>
In the case of the vpn client I'm interfacing with, I don't have the option
of passing such a script argument. I discovered that you can't send the ip4
config message before you reply to the connect message, because the reply of
the connect message starts the timer to wait for the ip4 config message.
That's a bug in network manager; the timer on the ip4 config message should
not terminate the connection unless it hasn't happened at all; instead, it
only shuts it down if it happens after the connect completes.
To avoid this, I simply inserted a one-second sleep after returning the
connect message, and then I send the ip4 config message.
I'm faking the parameters; I'm telling it that it's always tun0, which I
think my vpn client I'm stuck with will do, and I also need to give it the
local address on the tun0 device, which I am giving what it seems to usually
give, and I believe nm does nothing with this address.
> Is it necessary for a VPN plugin to allow network manager to manage the
> > routing and tunneling once the VPN is setup, or is it ok if the VPN
> plugin
> > does that itself?
>
> OpenVPN is started with --route-noexec and --ifconfig-noexec which
> means the OpenVPN is not change anything concerning routing or IP
> configuration.
I don't have the option of doing that in this case. :(
Thomas
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list
Specifying an IPv6 suffix
I want to control the IPv6 suffix for my interfaces and let the prefix be set with RA. Currently I can either have the RA prefix with the MAC address for the suffix, or I can specify a complete IPv6 address (and gateway) and ignore RA (doing this manually in the ifcfg-eth0 file as I don't see how to do this with Network manager). The first approach causes problems with DNS if I change the interface. The second approach causes problems if I change the network prefix. Or I could implement DHCPv6, but would still have to change its content if I change the MAC address. And I don't want to ge the DHCPv6 approach anyway. The way I want would be better:) but I don't see that it is supported. My current systems are Centos 5.5 and FC12, so I am stuck, probably with the world as it is, but at least with FC14, it would be nice ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
GSM modem via Bluetooth?
I have Nokia E51 and am using KDE with bluedevil; Modemmanager 0.4 and NM 0.8.2-rc1. I can browse phone and transfer files, but modemmanager does not display any available device when BT is activated. Is it supposed to work at all and if yes, what is requires to get it working? Pointers to documentation is appreciated. Thank you! -Andrey ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Fix for wrong handling of cid variable in mm-generic-gsm.c connect()
2010/11/2 Dan Williams : > On Sun, 2010-10-31 at 12:08 +0200, Maciej Grela wrote: >> Hi, >> >> I have recently noticed, that my Nokia E51 stopped working in >> NetworkManager. In mm debug I saw the following message: > > Hmm, did you give an APN in the config before connecting? If not, then > I think there's a few things we should do to handle that case better. > The patch is still clearly correct; though it would cause the code to > dial ATD*99***0#, which is invalid. If the phone accepts that, it's > wrong. I think what we should end up doing when there's no APN is just > dialing ATD*99# and let the modem decide, possibly screwing the user in > the process when the modem's stored APN is wrong. > I don't have an APN set in the config, so the cid == -1 and with the patch mm dials 'ATD*99#'. So this works correctly IMHO. The '*99#' is a 'fallback' number called when the APN is unknown and thus cid cannot be selected. > (APNs are stored in the *modem*, not the SIM, so if you ever change > providers and put in a different SIM, ATD*99# is guaranteed not to work) > I didn't know that, thanks for explanation. Best regards, Maciej Grela PS. The ICCID read fails for my sim, can this be a problem ? See below: ** (modem-manager:8763): DEBUG: <1288810506.760960> (ttyACM0): --> 'AT+CRSM=176,12258,0,0,10' ** (modem-manager:8763): DEBUG: <1288810506.54> (ttyACM0): <-- 'ERROR' ** (modem-manager:8763): DEBUG: Got failure code 100: Unknown error ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: is there anyone here who understands the vpn implementation
Hi Thomas,
On Wed, Nov 03, 2010 at 10:01:27AM -0700, Thomas Bushnell, BSG wrote:
> I've asked a few questions and gotten deafening silence. I'm not a bozo, and
> I was hoping for slightly more.
>
> Is there anyone here who understands the VPN plugin implementation in
> network manager?
I have looked into the way NM handles this. If I got it right it works
like this: For each type of VPN implementation (e.g. openvpn) there
exists a helper daemon which exports an D-Bus interface. The helper
VPN daemon is spawnding the real VPN deamon. In the case of OpenVPN it
will start the daemon with few general arguments (e.g. client mode
etc) and a script argument ('--up') which will be called when OpenVPN
changes state (e.g. gets connected). The script called by OpenVPN is a
callback function into the VPN helper daemon which results into an
D-Bus message to NM.
> Is it necessary for a VPN plugin to allow network manager to manage the
> routing and tunneling once the VPN is setup, or is it ok if the VPN plugin
> does that itself?
OpenVPN is started with --route-noexec and --ifconfig-noexec which
means the OpenVPN is not change anything concerning routing or IP
configuration.
> What is the mechanism by which the VPN plugin should communicate to network
> manager that the connection is live? nm_vpn_plugin_set_state (...,
> NM_VPN_SERVICE_STATE_STARTED) does not work, and the vpnc plugin doesn't
> even do that much, yet of course it works.
Haven't looked at that part.
HTH,
daniel
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: Is it possible that a command line interface to the network-manager functionality could be added?
Daenyth Blank writes: Hi Daenyth, >>> I do see connections defined in knetworkmanager but it needs >>> knetworkmanager running. >> >> Oh, indeed, I see those, too. But my need is to have a cmd line >> interface to networkmanager when I have broken my X install, so >> there's no way to start knetworkmanager. > You may be interested in my python-networkmanager library: > https://github.com/tweakt/python-networkmanager > > The wifi support isn't really there yet, and there's some class > restructuring that needs to be done, but you might be able to use it > as a starting point. Thanks for the suggestion. I'll have a look at it as soon as I find some spare time. Bye, Tassilo ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
