Re: [review] backport th/memleaks-nm-1-0

2015-03-13 Thread Thomas Haller 
On Thu, 2015-03-12 at 13:47 -0500, Dan Williams wrote:
> On Thu, 2015-03-12 at 16:38 +0100, Thomas Haller wrote:
> > On Wed, 2015-03-11 at 17:14 +0100, Thomas Haller wrote:
> > > On Thu, 2015-03-05 at 12:36 +0100, Thomas Haller wrote:
> > > > Hi all,
> > 
> > more backports ready, please see:
> >   th/memleaks-nm-1-0
> 
> Looks good to me, I pushed some cherry-picks from git master for a leak
> I found and some suppression updates for newer glib.
> 
> Dan

Thanks Dan.

merged:
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=050301d4d7ec6c4aafc49bfafb5494389b990d24

Thomas


signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [review] th/keyfile

2015-03-13 Thread Dan Williams 
Hi Thomas,

About th/keyfile...

> libnm: add _nm_utils_hash_values_to_ptrarray() function

What about g_hash_table_get_values() instead?  It returns the values as
a GList* instead of a GPtrArray, were you just worried about memory
allocation here?

The rest looks OK to me.  Do we need to update any testcases for the
sort ordering?

Dan

___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list