[PATCH] bluetooth: fix missing 'connected' notifications (rh #1255284)

[Dan Williams]

Because Bluez5 dropped DUN support, NM must do that manually which
includes emulating the "connected" property for Bluetooth devices when
DUN is used.  It does this by setting priv->connected = TRUE in
nm_bluez_device_connect_finish().

But for PAN, when NM does process the 'connected' property change
notification, priv->connected is already TRUE and
_take_variant_property_connected() does nothing.  Hence the
corresponding GObject property notification is not emitted,
nm-device-bt.c::check_connect_continue() will never return success, and
the activation times out.

To fix this, ensure that GObject notifications are emitted when the
device is connected, even if emulated internally.

---

diff --git a/src/devices/bluetooth/nm-bluez-device.c 
b/src/devices/bluetooth/nm-bluez-device.c
index cc44b9e..b703214 100644
--- a/src/devices/bluetooth/nm-bluez-device.c
+++ b/src/devices/bluetooth/nm-bluez-device.c
@@ -600,8 +600,10 @@ nm_bluez_device_connect_finish (NMBluezDevice *self,
return NULL;
 
device = (const char *) g_simple_async_result_get_op_res_gpointer 
(simple);
-   if (device && priv->bluez_version == 5)
+   if (device && priv->bluez_version == 5) {
priv->connected = TRUE;
+   g_object_notify (G_OBJECT (self), NM_BLUEZ_DEVICE_CONNECTED);
+   }
 
return device;
 }

___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: Bridge with alias interface

[Thomas Haller]

On Thu, 2015-10-22 at 10:15 -0600, Nathanael D. Noblet wrote:
> On Thu, 2015-10-22 at 17:39 +0200, Thomas Haller wrote:
> > Not with NM.
> > 
> > I didn't try it, but I don't think you can even do
> > that with kernel/brctl alone. A bridge slave needs an
> > ifindex, and alias interfaces don't have their own separate
> > device/ifindex.
> > Thus, you are anyway enslaving the whole eth0.
> > 
> 
> So the next question. Can I have a bridge with eth0 *and* an eth0:0
> alias and expect things to work?


Interface aliases are concerned with the IP configuration (Layer 3) of
the device. Once you enslave the device eth0 to a bridge, it has no
more layer 3 properties and thus it makes no sense to have IP
configuration there.

Enslave eth0 and configure your IP addresses on the bridge device
itself, like having a "br0:0" ...

Thomas



signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list