Re: [MM] [PATCH] novatel-lte: increase number of retries for connection status checks
Sounds good to me. Changed to 60s. Ben On Tue, May 28, 2013 at 12:47 AM, Aleksander Morgado wrote: > On 28/05/13 06:04, Ben Chan wrote: > > 60s seems a bit excessive as users most likely give up earlier. Revised > > the patch to have a 30s timeout. > > > > Remember that MM lets the connection attempt to be cancelled at any time > by Disconnect()-ing the Bearer during the connection attempt (best > effort is done to perform the disconnection), so connection managers can > actually let users give up whenever they want. Actually, IIRC there's a > 120s timeout in NetworkManager by default (to consider not only the > dialling, but also additional steps in SimpleConnect() like > authentication and such), with an effective timeout at the end of 60s in > most cases as that's the timeout MM uses by default for the dialling > step. Shouldn't we try to have the same timeout in MM side in all > plugins? (i.e. 60s). What do you think? > > > > > Thanks, > > Ben > > > > > > On Mon, May 27, 2013 at 12:52 AM, Aleksander Morgado > > mailto:aleksan...@lanedo.com>> wrote: > > > > On 26/05/13 08:45, Ben Chan wrote: > > > This patch increases the number of retries, from 4 to 10, for > > connection > > > status check during a connection / disconnection request, which > > handles > > > some scenario when the connection / disconnection request takes > more > > > than 5 seconds to complete. > > > > We recently updated most plugins and the generic implementation to > wait > > up to 60s to get the connection up. Do you really think that 10s is > > enough? > > > > > > > --- > > > plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > > index 31c5650..677bc3c 100644 > > > --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > > +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > > @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self, > > > callback, > > > user_data, > > > connect_3gpp); > > > -ctx->retries = 4; > > > +ctx->retries = 10; > > > > > > /* Get a 'net' data port */ > > > ctx->data = mm_base_modem_get_best_data_port (MM_BASE_MODEM > > (modem), > > > @@ -333,7 +333,7 @@ detailed_disconnect_context_new > > (MMBroadbandBearer *self, > > > callback, > > > user_data, > > > > > detailed_disconnect_context_new); > > > -ctx->retries = 4; > > > +ctx->retries = 10; > > > return ctx; > > > } > > > > > > > > > > > > -- > > Aleksander > > > > > > > -- > Aleksander > ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH] novatel-lte: increase number of retries for connection status checks
On 28/05/13 06:04, Ben Chan wrote: > 60s seems a bit excessive as users most likely give up earlier. Revised > the patch to have a 30s timeout. > Remember that MM lets the connection attempt to be cancelled at any time by Disconnect()-ing the Bearer during the connection attempt (best effort is done to perform the disconnection), so connection managers can actually let users give up whenever they want. Actually, IIRC there's a 120s timeout in NetworkManager by default (to consider not only the dialling, but also additional steps in SimpleConnect() like authentication and such), with an effective timeout at the end of 60s in most cases as that's the timeout MM uses by default for the dialling step. Shouldn't we try to have the same timeout in MM side in all plugins? (i.e. 60s). What do you think? > Thanks, > Ben > > > On Mon, May 27, 2013 at 12:52 AM, Aleksander Morgado > mailto:aleksan...@lanedo.com>> wrote: > > On 26/05/13 08:45, Ben Chan wrote: > > This patch increases the number of retries, from 4 to 10, for > connection > > status check during a connection / disconnection request, which > handles > > some scenario when the connection / disconnection request takes more > > than 5 seconds to complete. > > We recently updated most plugins and the generic implementation to wait > up to 60s to get the connection up. Do you really think that 10s is > enough? > > > > --- > > plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > index 31c5650..677bc3c 100644 > > --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self, > > callback, > > user_data, > > connect_3gpp); > > -ctx->retries = 4; > > +ctx->retries = 10; > > > > /* Get a 'net' data port */ > > ctx->data = mm_base_modem_get_best_data_port (MM_BASE_MODEM > (modem), > > @@ -333,7 +333,7 @@ detailed_disconnect_context_new > (MMBroadbandBearer *self, > > callback, > > user_data, > > > detailed_disconnect_context_new); > > -ctx->retries = 4; > > +ctx->retries = 10; > > return ctx; > > } > > > > > > > -- > Aleksander > > -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH] novatel-lte: increase number of retries for connection status checks
60s seems a bit excessive as users most likely give up earlier. Revised the patch to have a 30s timeout. Thanks, Ben On Mon, May 27, 2013 at 12:52 AM, Aleksander Morgado wrote: > On 26/05/13 08:45, Ben Chan wrote: > > This patch increases the number of retries, from 4 to 10, for connection > > status check during a connection / disconnection request, which handles > > some scenario when the connection / disconnection request takes more > > than 5 seconds to complete. > > We recently updated most plugins and the generic implementation to wait > up to 60s to get the connection up. Do you really think that 10s is enough? > > > > --- > > plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > index 31c5650..677bc3c 100644 > > --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > > @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self, > > callback, > > user_data, > > connect_3gpp); > > -ctx->retries = 4; > > +ctx->retries = 10; > > > > /* Get a 'net' data port */ > > ctx->data = mm_base_modem_get_best_data_port (MM_BASE_MODEM (modem), > > @@ -333,7 +333,7 @@ detailed_disconnect_context_new (MMBroadbandBearer > *self, > > callback, > > user_data, > > > detailed_disconnect_context_new); > > -ctx->retries = 4; > > +ctx->retries = 10; > > return ctx; > > } > > > > > > > -- > Aleksander > ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH] novatel-lte: increase number of retries for connection status checks
On 26/05/13 08:45, Ben Chan wrote: > This patch increases the number of retries, from 4 to 10, for connection > status check during a connection / disconnection request, which handles > some scenario when the connection / disconnection request takes more > than 5 seconds to complete. We recently updated most plugins and the generic implementation to wait up to 60s to get the connection up. Do you really think that 10s is enough? > --- > plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > index 31c5650..677bc3c 100644 > --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c > +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c > @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self, > callback, > user_data, > connect_3gpp); > -ctx->retries = 4; > +ctx->retries = 10; > > /* Get a 'net' data port */ > ctx->data = mm_base_modem_get_best_data_port (MM_BASE_MODEM (modem), > @@ -333,7 +333,7 @@ detailed_disconnect_context_new (MMBroadbandBearer *self, > callback, > user_data, > > detailed_disconnect_context_new); > -ctx->retries = 4; > +ctx->retries = 10; > return ctx; > } > > -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
[MM] [PATCH] novatel-lte: increase number of retries for connection status checks
This patch increases the number of retries, from 4 to 10, for connection status check during a connection / disconnection request, which handles some scenario when the connection / disconnection request takes more than 5 seconds to complete. --- plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c b/plugins/novatel/mm-broadband-bearer-novatel-lte.c index 31c5650..677bc3c 100644 --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self, callback, user_data, connect_3gpp); -ctx->retries = 4; +ctx->retries = 10; /* Get a 'net' data port */ ctx->data = mm_base_modem_get_best_data_port (MM_BASE_MODEM (modem), @@ -333,7 +333,7 @@ detailed_disconnect_context_new (MMBroadbandBearer *self, callback, user_data, detailed_disconnect_context_new); -ctx->retries = 4; +ctx->retries = 10; return ctx; } -- 1.8.2.1 ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
